Skip to content

Restore exclusive* dependencies, update metaschema #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Restore exclusive* dependencies, update metaschema #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions jsonschema-validation.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,9 @@
<t>
The value of "exclusiveMaximum" MUST be number, representing an exclusive upper limit for a numeric instance, or a boolean. Schemas SHOULD NOT use the boolean form.
</t>
<t>
If "exclusiveMaximum" is a boolean, then "maximum" MUST be present, and "exclusiveMinimum" (if present) MUST also be a boolean.
</t>
<t>
<cref>The boolean form of "exclusiveMaximum" is expected to be removed in the future.</cref>
</t>
Expand All @@ -280,6 +283,9 @@
<t>
The value of "exclusiveMinimum" MUST be number, representing an exclusive upper limit for a numeric instance, or a boolean. Schemas SHOULD NOT use the boolean form.
</t>
<t>
If "exclusiveMinimum" is a boolean, then "minimum" MUST be present, and "exclusiveMaximum" (if present) MUST also be a boolean.
</t>
<t>
<cref>The boolean form of "exclusiveMinimum" is expected to be removed in the future.</cref>
</t>
Expand Down
39 changes: 25 additions & 14 deletions schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,23 +54,38 @@
"default": {},
"multipleOf": {
"type": "number",
"minimum": 0,
"exclusiveMinimum": true
"exclusiveMinimum": 0
},
"maximum": {
"type": "number"
},
"exclusiveMaximum": {
"type": "boolean",
"default": false
},
"minimum": {
"type": "number"
},
"exclusiveMinimum": {
"type": "boolean",
"default": false
},
"oneOf": [
{
"exclusiveMaximum": {
"type": "number"
},
"exclusiveMinimum": {
"type": "number"
}
},
{
"exclusiveMaximum": {
"type": "boolean",
"default": false
},
"exclusiveMinimum": {
"type": "boolean",
"default": false
},
"dependencies": {
"exclusiveMaximum": [ "maximum" ],
"exclusiveMinimum": [ "minimum" ]
}
}
],
"maxLength": { "$ref": "#/definitions/positiveInteger" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is plain wrong. Firstly there is typo (type:'maximum'). A bigger concern is that exclusiveMaximum can have boolean form and exclusiveMinimum can be numeric, while this meta-schema won't allow it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach addresses it: #185 (comment)
Also anyOf is always better when it is possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@epoberezkin Fixed typo, thanks.

What you suggest in that comment on #185 is essentially what I had in #168 which was rejected. This was my attempt to split the difference between that and the refusal to use "dependencies" at all that defines @awwright's approach in #185.

In Draft 4 you can only do the boolean form. We have discussed (but not, IIRC, agreed on) eventually dropping the boolean form and using only numeric forms.

What is your use case for mixing numeric and boolean in the same schema object? That would be a very confusing schema to me. Note that if you use the boolean form in the root schema and numeric form in a child schema, or a $ref's schema, this meta-schema allows that just fine. It's only mixing the approaches in the same object that it avoids. In this case the "oneOf" is specifically to prevent mixing in a single object.

"minLength": { "$ref": "#/definitions/positiveIntegerDefault0" },
"pattern": {
Expand Down Expand Up @@ -144,9 +159,5 @@
"oneOf": { "$ref": "#/definitions/schemaArray" },
"not": { "$ref": "#" }
},
"dependencies": {
"exclusiveMaximum": [ "maximum" ],
"exclusiveMinimum": [ "minimum" ]
},
"default": {}
}