Skip to content

hyperschema: remove obsolete references to core terminology definitions #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 6, 2017

Conversation

dlax
Copy link
Member

@dlax dlax commented Apr 5, 2017

At the beginning of hyperschema document, there's:

The terms "schema", "instance", "property" and "item" are to be interpreted as defined in the JSON Schema core specification.

but core specification does no longer defines "property" and "item" (from 3cbfc8b AFAICT). I guess the former is assumed by JSON terminology; the latter may be confusing w.r.t. to collection+item terminology that appears in sections about links. So removing both references.

Denis Laxalde added 2 commits April 5, 2017 16:43
The "item" term is no longer defined in JSON Schema core document (from
3cbfc8b). So remove this reference from
hyperschema document.
As for "item", this term is no longer defined in JSON Schema core document
(from 3cbfc8b).
@handrews handrews added this to the draft-next (draft-6) milestone Apr 5, 2017
Copy link
Contributor

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the validation schema and it doesn't try to reference or define these either, although it uses the terms in the conventional manner.

So I agree that we don't need to define them here, and should definitely remove the dangling references.

@handrews
Copy link
Contributor

handrews commented Apr 6, 2017

@dlax feel free to update this to add yourself to the acknowledgement section

@dlax
Copy link
Member Author

dlax commented Apr 6, 2017

@dlax feel free to update this to add yourself to the acknowledgement section

@handrews done in 627801e.

@Relequestual Relequestual merged commit bd227e5 into json-schema-org:master Apr 6, 2017
@Relequestual
Copy link
Member

OK by me!

@dlax dlax deleted the hyperschema-terminology branch April 6, 2017 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants