Add minContains and maxContains #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlax
approved these changes
Dec 28, 2017
|
Two-day warning! If anyone else wants to comment on this you have two days before we hit the two week threshold, at which point I will merge it (since there is one approval already.) |
|
@handrews do you think it is worth adding the note about |
This value is only useful when "maxContains" is present.
|
@epoberezkin thanks, updated. |
Relequestual
approved these changes
Jan 19, 2018
|
Note that this is temporarily on hold pending decisions on whether to do an interim bugfix release. It is not abandoned! |
This was referenced Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #441