Skip to content

Reference ECMAScript 11.0 specifically (#821) #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 4, 2020
Merged

Reference ECMAScript 11.0 specifically (#821) #965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1e7cd49
Fixes 821
Relequestual Aug 10, 2020
7e31d17
Reference ECMAScript 10.0 specifically for the purposes of optional r…
Relequestual Sep 30, 2020
d74ddb4
Update ecma262 section numbers
Relequestual Sep 30, 2020
9b96d6a
Add note regarding regular expression unicode flag requirement
Relequestual Oct 14, 2020
bb9cba6
Fix duplicated phrase
Relequestual Oct 26, 2020
44a473e
Merge branch 'master' into fixes/821
Relequestual Oct 26, 2020
0143f21
Reference ECMAScript 11th Edition specifically for the purposes of op…
Relequestual Sep 30, 2020
9186315
Fix how ECMA-262 is used and referenced
Relequestual Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions jsonschema-core.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,12 @@
Keywords MAY use regular expressions to express constraints, or constrain
the instance value to be a regular expression.
These regular expressions SHOULD be valid according to the regular expression
dialect described in <xref target="ecma262">ECMA 262, section 15.10.1</xref>.
dialect described in <xref target="ecma262">ECMA-262, section 21.2.1</xref>.
</t>
<t>
Regular expressions SHOULD be built with the "u" flag (or equivilent) to provide
Unicode support, or processed in such a way which provides which provides Unicode
as defined by ECMA-262.
</t>
<t>
Furthermore, given the high disparity in regular expression constructs support,
Expand Down Expand Up @@ -2480,7 +2485,7 @@
<t>
The value of "patternProperties" MUST be an object. Each property name
of this object SHOULD be a valid regular expression, according to the
ECMA 262 regular expression dialect. Each property value of this object
ECMA-262 regular expression dialect. Each property value of this object
MUST be a valid JSON Schema.
</t>
<t>
Expand Down Expand Up @@ -3291,11 +3296,11 @@ https://example.com/schemas/common#/$defs/count/minimum
&RFC8259;
&ldp;
<reference anchor="ecma262"
target="http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-262.pdf">
target="https://www.ecma-international.org/ecma-262/11.0">
<front>
<title>ECMA 262 specification</title>
<title>ECMA-262, 11th edition specification</title>
<author/>
<date/>
<date month="June" year="2020" />
</front>
</reference>
</references>
Expand Down Expand Up @@ -3924,7 +3929,9 @@ https://example.com/schemas/common#/$defs/count/minimum
<t>Rename $recursive* to $dynamic*</t>
<t>$dynamicAnchor defines a fragment like $anchor</t>
<t>$dynamic* (previously $recursive) no longer use runtime base URI determination</t>
<t>Reference ecma262 11th edition for regular expression support</t>
<t>Define Compound Schema Documents (bundle) and processing</t>
<t>Reference ECMA-262, 11th edition for regular expression support</t>
<t></t>
<t></t>
<t></t>
Expand Down
16 changes: 8 additions & 8 deletions jsonschema-validation.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@
<section title="pattern" anchor="pattern">
<t>
The value of this keyword MUST be a string. This string SHOULD be a
valid regular expression, according to the ECMA 262 regular expression
valid regular expression, according to the ECMA-262 regular expression
dialect.
</t>
<t>
Expand Down Expand Up @@ -898,12 +898,12 @@
</t>
<t>
A regular expression, which SHOULD be valid according to the
<xref target="ecma262">ECMA 262</xref> regular expression dialect.
<xref target="ecma262">ECMA-262</xref> regular expression dialect.
</t>
<t>
Implementations that validate formats MUST accept at least the subset of
ECMA 262 defined in the <xref target="regexInterop">Regular Expressions</xref>
section of this specification, and SHOULD accept all valid ECMA 262 expressions.
ECMA-262 defined in the <xref target="regexInterop">Regular Expressions</xref>
section of this specification, and SHOULD accept all valid ECMA-262 expressions.
</t>
</section>
</section>
Expand Down Expand Up @@ -1316,11 +1316,11 @@
&RFC6901;
&RFC8259;
<reference anchor="ecma262"
target="http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-262.pdf">
target="https://www.ecma-international.org/ecma-262/11.0">
<front>
<title>ECMA 262 specification</title>
<title>ECMA-262, 11th edition specification</title>
<author/>
<date/>
<date month="June" year="2020" />
</front>
</reference>
<reference anchor="relative-json-pointer">
Expand Down Expand Up @@ -1434,7 +1434,7 @@
<list style="symbols">
<t>Correct email format RFC reference to 5321 instead of 5322</t>
<t>Clarified the set and meaning of "contentEncoding" values</t>
<t></t>
<t>Reference ECMA-262, 11th edition for regular expression support</t>
<t></t>
<t></t>
<t></t>
Expand Down