Fix 988 - Inconsistencies with schema uri and empty fragment URIs #997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
about-code
changed the title
|
Ah right, yes, that's correct. We left it as SHOULD to keep backwards compat rather than nit picking in this instance, iirc. |
Relequestual
approved these changes
Sep 26, 2020
|
Thank you Andreas for your contribution! Every little helps! |
|
You're welcome. I very much appreciate the hard work and time you and your collaborators dedicate to this project and
was exactly what I thought would be a good way to show my gratitude. :-) |
|
My first PR was for jQuery docs! =] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #988 and other inconsistencies regarding empty fragments.
@Relequestual regarding the issue and empty fragments you wrote
The exact wording of the spec with respect to
$id(not$schema) currently isI guess you referred to this part of the spec since I could not find any other mentioning of empty fragments. I read this as
http://example.com/my-schema-id#non-emptymust not be usedhttp://example.com/my-schema-id#should not be usedI am only writing this because this PR picks up on your original comment and also removes some empty fragments which I assume are very likely unintended while not being totally against the spec itself, though.