Skip to content

Sample interpreter test suite #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Aug 24, 2021

This adds a sample testing suite test for the keyword not. I don't think they are fully there (the output) but at least it is a start.

We are using somewhat the same structure as the official JSON Schema test suite.

However, instead of having a tests property, we use definition. This is what I refer to as the Data definition format here - #8 (comment).

At the moment I use a JSON Schema variant, somewhat the same properties as the spec, but instead of having the meaning of validation, it is a data definition.

@jdesrosiers
Copy link
Member

The not keyword is not a good example to start with. We still have to discuss what not even means in a DDL context. I'm inclined to simply say it's a pure validation keyword and has no meaning when interpreted as a DDL.

@jonaslagoni
Copy link
Member Author

The not keyword is not a good example to start with

Good point, gonna redo with your examples 🙂

We still have to discuss what not even means in a DDL context. I'm inclined to simply say it's a pure validation keyword and has no meaning when interpreted as a DDL.

I guess it is 😄

To me, there are no doubts that it must be included, as to whether we whitelist or blacklist (with not) types, we still indirectly say what the underlying data format should be.

@jonaslagoni jonaslagoni closed this Oct 7, 2021
@jonaslagoni jonaslagoni deleted the feature/add_sample_testing_suite branch October 7, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants