-
-
Notifications
You must be signed in to change notification settings - Fork 273
Create a new page for Community inside the Overview Section of the Docs. #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@benjagm working on it |
Thanks @Min2who ! We didn't have a design yet but in my mind this is the a great example of Community page: https://www.asyncapi.com/community Happy to provide a low-level prototype of the page. |
@benjagm i should work on this or not as you have assigned it to yourself |
Hii @benjagm do you have the low level prototype ready, if yes can you please share it here, i would like to work on this and atleast have a foundation set up for the page |
This is the prototype of the new page I'd love to have. Sections:
For this prototype I used screenshot from others sites so you will need to adapt colours and styles to JSON Schema. Please leave fake text for all sections and as soon we are fine with the design I'll complete the PR with the real texts/links. |
can i get assigned and work on it @benjagm |
I have intrest in this kind of work, may I get it assigned to start work immediately? |
Thanks for your interest @pi600 All yours. The prototype is just low fidelity. You'll need to adjust all the styles to JSON Schema and be creative. Reach out to me in Slack anytime if you have doubts. For the text, please use fake text for all sections and as soon we are fine with the design I'll complete the PR with the real texts/links. This new page will go under the overview section in the sidebar of the docs. Thanks! |
@pi600 let us know if you need support. @varunsh17 offered help with this one. @utnim2 Could you please join me as reviewer of the PR? |
Hi @pi600 we'll need to increate the priority of this issue because there are others depending on it. I will make this available for others to work on this. Thanks. |
I want to work on this issue |
Thanks helping with this one. All yours. |
Thanks for assign to me 🫠@benjagm |
Hey @officeneerajsaini When creating the border/shadow effects for each big card/section please use the same format we are using in the landing page for this section: ![]() |
@benjagm maybe this issue related to Json Scheme Docs ? Because i need to done 1 Doc Contribution for Qualification Task . |
I am sorry but I dont fully understand this comment. Can you please clarify? |
@benjagm Sorry for any confusion, I'm just asking if this issue is related to documentation. |
Hey @officeneerajsaini you need to implement the above components for creating a new community page |
@utnim2 yes |
Hey @officeneerajsaini have you faced this error while running |
@utnim2, when I try to commit on my local machine, those errors are showing. But now I've fixed all of them. |
With the issue #322 we added specific checks for linting error, format fix and typechecks. This is important when we have this high number of contributors. You will need to fix it manually or use prettier to fix it for you with a command like this:
|
Thank You @benjagm |
Can you please change the target branch to https://github.com/json-schema-org/website/tree/web-release-3? |
so I need to submit my pull request in the following format: https://github.com/json-schema-org/website/tree/web-release-3/my-branch. ? am i right ? |
I think we can add this to the community section in the navbar. That should be a good place for it. What do you say about this, Benjagm? |
|
is this open? |
yes , i am still working on it . |
This is now merged into the dev branch. |
Description
Create a new page for Community inside the Overview Section of the Docs.
Do you think this work might require an Architectural Decision Record (ADR)? (significant or noteworthy)
No
The text was updated successfully, but these errors were encountered: