Skip to content

[bug] - Revert release notes changes #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Conversation

benjagm
Copy link
Collaborator

@benjagm benjagm commented Oct 9, 2024

Summary

After releasing the new structure of release notes making it a section of each spec version page we found that the redirect we created didn't. work in some scenarios producing some breaking changes. In addition, when embedding the release notes into the spec page we found that the fragments generated for subsections wasn't informative enough, therefore we are deciding to revert that change, making the release notes accessible as they were before.

Linked discussion: #955 (comment)

Issues:

Revert the old release notes pages
@benjagm benjagm requested a review from a team as a code owner October 9, 2024 04:22
Copy link

github-actions bot commented Oct 9, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview d7d3ffd

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e4f6e8b) to head (d7d3ffd).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1010   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjagm benjagm merged commit cec0d01 into main Oct 12, 2024
11 checks passed
@benjagm benjagm deleted the benjagm-restore-release-notes branch October 12, 2024 09:38
Julian added a commit to python-jsonschema/jsonschema that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant