Skip to content

Updated favicon settings #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2023
Merged

Updated favicon settings #3

merged 1 commit into from
Apr 20, 2023

Conversation

PaulWaller
Copy link
Contributor

Hi. This is the first contribution to this fork.
We have updated the favicon image for light and dark settings.

  • Removed duplicate file name from the light setting.
  • Replaced the blue favicon with a lighter tone (#b1cdfb) . ico file to enhance visibility against the background. This is a lighter tone of the primary blue (#3b82f6) used in the JSON Schema logo.
  • Contrast for the dark mode checked across accessibility colour filters. Contrast Ratio: 8.27:1.
    image
    image

@PaulWaller PaulWaller mentioned this pull request Apr 11, 2023
Closed
benjagm
benjagm approved these changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@benjagm benjagm closed this Apr 20, 2023
@benjagm benjagm reopened this Apr 20, 2023
@benjagm benjagm merged commit bc39aad into json-schema-org:main Apr 20, 2023
DhairyaMajmudar pushed a commit to DhairyaMajmudar/json-schema-website that referenced this pull request Jul 24, 2024
@kwennB
Merge pull request json-schema-org#3 from DhairyaMajmudar/new-spec-st…
b144b8f 
…ructure

Draft 07 Fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjagm benjagm benjagm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulWaller @benjagm