Skip to content

docs structure #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2023
Merged

docs structure #31

merged 3 commits into from
Apr 27, 2023

Conversation

OlliesWorld
Copy link
Contributor

updated doc structure
added subtitle with different styles

@OlliesWorld OlliesWorld requested a review from benjagm April 26, 2023 15:44
@OlliesWorld OlliesWorld linked an issue Apr 26, 2023 that may be closed by this pull request
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! THANKS!

Left some comments.

<DocLink uri='/understanding-json-schema/what-is-json-schema' label='What is JSON Schema?' />
<SegmentHeadline label='Getting Started' />
<DocLink uri='/learn/getting-started-step-by-step' label='Creating your first schema' />
<SegmentHeadline label='Example' />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples

<DocLink uri='/understanding-json-schema/what-is-json-schema' label='What is JSON Schema?' />
<SegmentHeadline label='Getting Started' />
<DocLink uri='/learn/getting-started-step-by-step' label='Creating your first schema' />
<SegmentHeadline label='Example' />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples is not a top level category, it is a 2nd level category dependant of Getting Started.

Screenshot 2023-04-26 at 20 14 05

<DocLink uri='/understanding-json-schema/reference/comments' label='$defs' />
<DocLink uri='/understanding-json-schema/structuring' label='Recursion' />
<DocLink uri='/understanding-json-schema/reference/conditionals' label='Extending Recursive Schemas' />
<DocLink uri='/understanding-json-schema/reference/non_json_data' label='Bundling' />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add top level category at the bottom of the menu called specification linking to "/specification"
Screenshot 2023-04-26 at 20 16 05

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 512a538
Status: ✅  Deploy successful!
Preview URL: https://606ac068.website-2v2.pages.dev
Branch Preview URL: https://22-implement-new-structure.website-2v2.pages.dev

View logs

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Roni. Thanks a lot.

@benjagm benjagm merged commit b844a6e into main Apr 27, 2023
@benjagm benjagm deleted the 22-implement-new-structure branch April 27, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the new website docs structure
2 participants