feat: added Dark theme to the website #365

Gmin2 · 2024-02-26T14:19:22Z

Resolves #130
Summary:

Added dark mode to the website completed the home page

https://www.loom.com/share/9f704d494b8146d4a795d2bfaec64c71

Todo

Docs page
Blog Page
Implementation Page

Gmin2 · 2024-02-28T06:14:04Z

Hi @praveen-rikhari, I hope you're still actively working on the issue. If possible, could you try to expedite the process a bit? We're encountering merge conflicts from various source.
Thank you for your attention to this matter

benjagm · 2024-02-28T17:20:43Z

@utnim2 great job so far here! Looks great. Now is time to Praveen to continue the great work done.

jayprakash25 · 2024-02-28T18:44:36Z

Hi @utnim2 . May I what else is to be done in the feature?

Gmin2 · 2024-02-28T19:19:32Z

Hi @utnim2 . May I what else is to be done in the feature?

You can complete the docs page and implementations page and one suggestion please prioritize it as it covers to touch the whole codebase of the website it will create more merge conflict as more as we delay it

@jayprakash25

jayprakash25 · 2024-02-29T02:11:09Z

Hi @utnim2 . May I what else is to be done in the feature?

You can complete the docs page and implementations page and one suggestion please prioritize it as it covers to touch the whole codebase of the website it will create more merge conflict as more as we delay it

@jayprakash25

Understood, I'll update my progress

jayprakash25 · 2024-02-29T04:31:19Z

@utnim2 only adding the dark theme is the task right?

Gmin2 · 2024-02-29T05:53:38Z

@utnim2 only adding the dark theme is the task right?

Yes @jayprakash25

jayprakash25 · 2024-02-29T13:20:42Z

Hi @utnim2 . The dark theme for docs is done.

jayprakash25 · 2024-02-29T13:21:08Z

Should I directly send pr to the main repo?

Gmin2 · 2024-02-29T14:30:18Z

Should I directly send pr to the main repo?

Hey @jayprakash25 please refer to this guide

jayprakash25 · 2024-02-29T15:38:03Z

I cannot push, as it says permisiion denied.

Gmin2 · 2024-02-29T15:45:50Z

I cannot push, as it says permisiion denied.

I have sent you permission please accept it and then you can push the changes

jayprakash25 · 2024-02-29T16:52:57Z

Yes, I pushed the changes for the docs page. Apologies for the delay, I'll push remaining pages as soon as possible @utnim2. I'm starting with the implementations page now

Gmin2 · 2024-02-29T16:57:57Z

Yes, I pushed the changes for the docs page. Apologies for the delay, I'll push remaining pages as soon as possible @utnim2. I'm starting with the implementations page now

Hey @jayprakash25 implementations page is half done already.You can pull the changes from the branch and start working on the rest part

Thanks

jayprakash25 · 2024-02-29T17:03:03Z

@utnim2 will this commits be acknowledged as colloborative contributions?

Gmin2 · 2024-02-29T17:04:31Z

@utnim2 will this commits be acknowledged as colloborative contributions?

A big big yes

jayprakash25 · 2024-02-29T17:25:22Z

@utnim2 is this table theme okay?

Gmin2 · 2024-02-29T17:27:07Z

@utnim2 is this table theme okay?

tagging @benjagm

jayprakash25 · 2024-02-29T17:34:26Z

https://www.loom.com/share/cff504d04535434b9d57c3c889247418?sid=d6298aa7-2959-4692-a236-5e3273cef9e0
preview of docs page

Gmin2 · 2024-02-29T17:39:23Z

https://www.loom.com/share/cff504d04535434b9d57c3c889247418?sid=d6298aa7-2959-4692-a236-5e3273cef9e0 preview of docs page

nice going @jayprakash25
Great progeress

kx412764776 · 2024-02-29T19:33:27Z

@utnim2 @jayprakash25 Can I contribute to this task yet?

Gmin2 · 2024-03-01T07:12:03Z

@utnim2 @jayprakash25 Can I contribute to this task yet?

@kx412764776 this issue is near to completion. You can look at some other issue

Thanks !

Gmin2 · 2024-03-09T15:45:45Z

@utnim will u take care of the search icon, i have done the first 2 changes.

are you doing the search icon

jayprakash25 · 2024-03-09T15:48:43Z

@utnim will u take care of the search icon, i have done the first 2 changes.

are you doing the search icon

I was hoping u could take on the search icon..

Gmin2 · 2024-03-09T15:54:59Z

@utnim will u take care of the search icon, i have done the first 2 changes.

are you doing the search icon

I was hoping u could take on the search icon..

i guess you have edited the message

jayprakash25 · 2024-03-09T15:57:24Z

@utnim will u take care of the search icon, i have done the first 2 changes.

are you doing the search icon

I was hoping u could take on the search icon..

i guess you have edited the message

I meant I have done sidebar icons not the search one....

Gmin2 · 2024-03-09T16:00:24Z

cool i am doing it

jayprakash25 · 2024-03-09T16:01:52Z

cool i am doing it

Yep, Thank u

jayprakash25 · 2024-03-10T12:23:19Z

Done with the search icon?

jayprakash25 · 2024-03-11T12:32:01Z

@utnim2 any updates yet

jayprakash25 · 2024-03-12T12:31:10Z

Hi @utnim2, I hadn't heard back regarding the search icon, so I went ahead and made the necessary changes. I hope that's okay.
@benjagm I have made it similar to asyncApi heres the link
https://www.loom.com/share/aa5905f6c6224346909c18b2328043f3?sid=2f2fc9a0-23e3-44ab-9bfb-ed4c33868da8

benjagm

This is looking really amazing!!

Just found some small things but I decided to record a video to better explain what is pending.

Let's go! We are almost there!

See comments in the code and this video (with audio):
https://github.com/json-schema-org/website/assets/40007659/293005b7-0ead-49fd-8b35-06c95dd6c790

benjagm · 2024-03-12T13:27:00Z

.eslintrc.js

@@ -32,7 +32,7 @@ module.exports = {

    'react/jsx-curly-spacing': ['error', { when: 'never', children: true }],
    indent: ['error', 2, { SwitchCase: 1 }],
-    'linebreak-style': ['error', 'windows'],
+    'linebreak-style': ['error', 'unix'],


Can I ask what is this change doing?

I adjust eslint.js line endings to CRLF for local development on Windows to prevent linting errors. Before pushing, I revert them to LF to maintain consistency with our project's Unix line endings.

benjagm · 2024-03-12T13:27:40Z

components/Layout.tsx

@@ -138,6 +136,8 @@ const MainNavigation = () => {
  const section = useContext(SectionContext);
  const showMobileNav = useStore((s: any) => s.overlayNavigation === 'docs');

+  const { theme } = useTheme();


Let's make sure light is the default theme when accessing for the first time.

benjagm · 2024-03-12T13:35:09Z

You will need to resolve the merge conflicts as well:

jayprakash25 · 2024-03-12T15:41:18Z

@utnim2 Taking on those issues now, informing to prevent overlap. Could use your help with any merge conflicts later.

jayprakash25 · 2024-03-12T18:34:25Z

https://www.loom.com/share/04e4609521514c76b7cb2323c122736a?sid=cb7ad52e-a6bb-4d11-b8f1-a6fd2ae294f1
@benjagm The mentioned changes..

jayprakash25 · 2024-03-12T18:38:46Z

@utnim2 we have merge conflicts. Can you take care of resolving them? Let me know.

Gmin2 · 2024-03-12T18:55:55Z

@utnim2 we have merge conflicts. Can you take care of resolving them? Let me know.

as you have done this changes you can proceed with resolving the conflicts @jayprakash25

jayprakash25 · 2024-03-13T11:59:17Z

@utnim2 @benjagm everything is done.

benjagm

This has been and outstanding job. Congrats!!!!

@jayprakash25 @utnim2

All good on my end!

jayprakash25 · 2024-03-13T12:14:58Z

Thank you @benjagm . Is there any other issue I could help with?

jayprakash25 · 2024-03-13T12:20:21Z

@benjagm Although I didn't submit(pr) it, I contributed to the work. Can I include this contribution in my proposal?

benjagm · 2024-03-13T12:21:23Z

@benjagm Although I didn't submit(pr) it, I contributed to the work. Can I include this contribution in my proposal?

Absolutely yes!!!

* getting back the lost changes * search box fix

* Fix: Dark theme footer style (#529) * fix: dark theme footer section styling & coloring * fixed the footer space issue in specification and docs page * handled the overflow issue while opening search bar (#544) * Fix: Getting back the lost changes from PR #365 (#537) * getting back the lost changes * search box fix * Bug: Sponsor logos are not optimized for dark mode (#532) * add gradient to show spons logo * fix prettier * fix * Update index.page.tsx * remove stoplight and retool * Update index.page.tsx * add dark mode images * fix * Fix tabs * Fix theme toggle * Fix and merge dark theme There was a problem with this PR: #544 Now everything works. * . * . --------- Co-authored-by: Sahil Shadwal <[email protected]> Co-authored-by: Aditya Sharma <[email protected]> Co-authored-by: Dhairya Majmudar <[email protected]> Co-authored-by: SATYAM KUMAR <[email protected]>

Gmin2 marked this pull request as draft February 26, 2024 15:57

Gmin2 marked this pull request as ready for review February 28, 2024 13:01

Gmin2 closed this Feb 28, 2024

Gmin2 reopened this Feb 28, 2024

benjagm mentioned this pull request Feb 28, 2024

Add dark mode to the site #130

Closed

benjagm assigned Gmin2 Feb 28, 2024

benjagm marked this pull request as draft February 28, 2024 17:19

benjagm added the Status: In Progress This issue is being worked on, and has someone assigned. label Feb 29, 2024

JeelRajodiya mentioned this pull request Mar 10, 2024

✨ Enhancement: Dark Mode #501

Closed

search icon

ab893d6

Gmin2 requested a review from a team as a code owner March 12, 2024 12:34

benjagm requested changes Mar 12, 2024

View reviewed changes

reviewed changes are done

27350a5

Merge and resolve conflicts with main branch

75c2fe6

benjagm approved these changes Mar 13, 2024

View reviewed changes

benjagm merged commit 38fe398 into json-schema-org:main Mar 13, 2024

This was referenced Mar 13, 2024

🐛 Bug: Getting the lost changes from the merger of dark theme pr. #528

Closed

Fix: Getting back the lost changes from PR #365 #537

Merged

benjagm pushed a commit that referenced this pull request Mar 15, 2024

Fix: Getting back the lost changes from PR #365 (#537)

e819186

* getting back the lost changes * search box fix

Uh oh!

feat: added Dark theme to the website #365

feat: added Dark theme to the website #365

Uh oh!

Conversation

Gmin2 commented Feb 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gmin2 commented Feb 28, 2024

Uh oh!

benjagm commented Feb 28, 2024

Uh oh!

jayprakash25 commented Feb 28, 2024

Uh oh!

Gmin2 commented Feb 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jayprakash25 commented Feb 29, 2024

Uh oh!

jayprakash25 commented Feb 29, 2024

Uh oh!

Gmin2 commented Feb 29, 2024

Uh oh!

jayprakash25 commented Feb 29, 2024

Uh oh!

jayprakash25 commented Feb 29, 2024

Uh oh!

Gmin2 commented Feb 29, 2024

Uh oh!

jayprakash25 commented Feb 29, 2024

Uh oh!

Gmin2 commented Feb 29, 2024

Uh oh!

jayprakash25 commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gmin2 commented Feb 29, 2024

Uh oh!

jayprakash25 commented Feb 29, 2024

Uh oh!

Gmin2 commented Feb 29, 2024

Uh oh!

jayprakash25 commented Feb 29, 2024

Uh oh!

Gmin2 commented Feb 29, 2024

Uh oh!

jayprakash25 commented Feb 29, 2024

Uh oh!

Gmin2 commented Feb 29, 2024

Uh oh!

kx412764776 commented Feb 29, 2024

Uh oh!

Gmin2 commented Mar 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gmin2 commented Mar 9, 2024

Uh oh!

jayprakash25 commented Mar 9, 2024

Uh oh!

Gmin2 commented Mar 9, 2024

Uh oh!

jayprakash25 commented Mar 9, 2024

Uh oh!

Gmin2 commented Mar 9, 2024

Uh oh!

jayprakash25 commented Mar 9, 2024

Uh oh!

jayprakash25 commented Mar 10, 2024

Uh oh!

jayprakash25 commented Mar 11, 2024

Uh oh!

jayprakash25 commented Mar 12, 2024

Uh oh!

benjagm left a comment

Choose a reason for hiding this comment

Uh oh!

benjagm Mar 12, 2024

Choose a reason for hiding this comment

Uh oh!

jayprakash25 Mar 12, 2024

Gmin2 commented Feb 26, 2024 •

edited

Loading

Gmin2 commented Feb 28, 2024 •

edited

Loading

jayprakash25 commented Feb 29, 2024 •

edited

Loading

Gmin2 commented Mar 1, 2024 •

edited

Loading