Feature/openjs foundation logo copyright #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjagm
requested changes
Apr 12, 2023
components/Layout.tsx
Outdated
| <div className='absolute text-sm bottom-0 mb-8'>© Copyright JSON Schema Organisation 2023</div> | ||
| </div> | ||
| <div className='flex flex-col items-start col-start-2 md:col-start-2 md:col-span-1 sm:col-start-1 sm:col-span-2'> | ||
| <img className='h-16 mb-3.5' src="/img/logos/openjs_foundation-logo-horizontal-color.svg" alt="color openjs foundation logo"></img> |
There was a problem hiding this comment.
I am getting some error when executing the build command of the site and seems to be related to the usage of double quotes:
Failed to compile.
./components/Layout.tsx
307:40 Error: Unexpected usage of doublequote. jsx-quotes
307:101 Error: Unexpected usage of doublequote. jsx-quotes
308:20 Error: Unexpected usage of doublequote. jsx-quotes
308:99 Error: Unexpected usage of doublequote. jsx-quotes
308:252 Error: Unexpected usage of doublequote. jsx-quotes
308:430 Error: Unexpected usage of doublequote. jsx-quotes
308:544 Error: Unexpected usage of doublequote. jsx-quotes
308:662 Error: Unexpected usage of doublequote. jsx-quotes
308:816 Error: Unexpected usage of doublequote. jsx-quotes
309:20 Error: Unexpected usage of doublequote. jsx-quotes
309:97 Error: Unexpected usage of doublequote. jsx-quotes
309:201 Error: Unexpected usage of doublequote. jsx-quotes
309:309 Error: Unexpected usage of doublequote. jsx-quotes
309:421 Error: Unexpected usage of doublequote. jsx-quotes
309:517 Error: Unexpected usage of doublequote. jsx-quotes
309:631 Error: Unexpected usage of doublequote. jsx-quotes
309:747 Error: Unexpected usage of doublequote. jsx-quotes
309:859 Error: Unexpected usage of doublequote. jsx-quotes
info - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Could it be possible to use single quotes to see if that fix the message?
There was a problem hiding this comment.
Pushed a commit removing double quotes and replacing with single quotes.
| <Logo /> | ||
| <a href='https://opencollective.com/json-schema' className='text-sm text-slate-400 hover:text-slate-500 pt-3 mt-2'>Open Collective</a> | ||
| <a href='/understanding-json-schema/credits' className='text-sm text-slate-400 hover:text-slate-500 pt-3'>Acknowledgments</a> | ||
| </div> | ||
| </footer> | ||
| ) | ||
|
|
||
| const OpenJS = () => ( |
There was a problem hiding this comment.
I reviewed how this 2 columns footer looks like and I'd like to suggest trying single column approach like https://loopback.io/
There was a problem hiding this comment.
Pushed a commit revising the responsive layout for OpenJS artifacts and adjusted the overl padding and margins for the footer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added OpenJS Foundation logo and copyright content from https://github.com/openjs-foundation/artwork#copyright-notices-for-project-website-footers to a new section of the footer.
Adjusted responsive styles.