Skip to content

Add workflow to update landscape tooling #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DarhkVoyd
Copy link
Member

@DarhkVoyd DarhkVoyd commented Aug 1, 2024

What kind of change does this PR introduce?
This PR aims to add a workflow, to track changes to the tooling data file and update tools in our landscape tooling category when tooling data changes.

NOTE: We need to add a fine-grained personal access token named PERSONAL_ACCESS_TOKEN, with write access to Actions of landscape repository to have appropriate authentication.

Issue Number:

  • Closes #___
  • Related to #___
  • Others?

Screenshots/videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

@DarhkVoyd DarhkVoyd added the GSoC Google Summer of Code related label Aug 1, 2024
@DarhkVoyd DarhkVoyd requested a review from a team as a code owner August 1, 2024 13:43
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Clean and simple.

Thanks DV!

@benjagm benjagm merged commit cd00318 into json-schema-org:web-release-tooling Aug 7, 2024
4 of 6 checks passed
@aialok
Copy link
Member

aialok commented Aug 7, 2024

we can use our json-schema-bot token instead of PAT.

@benjagm
Copy link
Collaborator

benjagm commented Aug 7, 2024

You are totally right! My bad! Can you update it DV?

@DarhkVoyd
Copy link
Member Author

DarhkVoyd commented Aug 7, 2024

Hey, sure! I didn't have access to existing token names so I just assumed a new token. Can you provide the name of the existing token? Moreover, please ensure that the token has read and write actions permissions.
My other thought is GitHub is moving forward with fine grained tokens from classical token to sandbox each token use. So, we could also ensure fine grained permission rights for each token and its consumer. Let me know !

@aialok
Copy link
Member

aialok commented Aug 7, 2024

Below is only step need to add to create token and using id you can use that token in other step.

Screenshot_20240808_003042_GitHub.jpg

You can also checkout linkchecker workflow, where are using that bot to create issue.

We might not have permission to trigger workflow but we can update permissiom for it easily.

Also this bot has organisation wise access and this is better approach than using Personal Access token fine grained or classic.

@DarhkVoyd
Copy link
Member Author

Got it, Thanks! I think there was some miscommunication from my side, its not a personal token per say, it was just any token with actions permission I just named it "Personal Access Token"

@aialok
Copy link
Member

aialok commented Aug 7, 2024

Got it, Thanks! I think there was some miscommunication from my side, its not a personal token per say, it was just any token with actions permission I just named it "Personal Access Token"

Good part about github app token is that it get destroy after the action finish : )

benjagm added a commit that referenced this pull request Sep 4, 2024
* [data]: Data Preparation for Improved Data Model (#738)

* add validators to updated tooling data

* migrate hardcoded tooling data to updated model

* refine structure

* fix, clean, and add environment field

* add dependsOnValidators field

* remove empty fields

* conform to ecosystem tooling identification schema

* remove incorrect draft

* fix apache 2.0 license to spdx identifier

* [pages][tools]: Redesign UI/UX for Tooling Page (#808)

* initial redesign migration

* remove environments groupby

* add trigger update landscape tooling workflow (#838)

* [pages][tools]: Implement Tooling Analytics and Integrate Bowtie Report (#858)

* [pages][tools]: Prepare Tooling Page for Release

Closes: #780

* improve dropdownmenu and sidebar with svgr logo

better sidebar

better tooling table

* add ToolingTable

* fix sidebar and query params

* improve tooling data table

fix

* fix mobile responsive

* use css columns in modal

* use modal svgr icon

remove margins in tooling modal

* add initial analytics

* add sort by bowtie

* add analytics schema and fix sidebar bug

* fix CORS error

redirect follow is critical. Also, setting content-type header to
text/plain is critical, even if sending JSON, as "text/plain" does not
trigger the browser's preflight requests (which are unsupported by
Google here)

* update schema to remove source and homepage

* update yarn lock

* update call to action and issue template

* Pushed changes to improve style

* update dependencies

* fix json path types build error

* remove unused file

* update redirects

* update internal links

* fix linting errors

* add backend api

* fix bowtie api integration and add skeleton placeholder

* fix bowtie served over https

* sort toolingData drafts

* fix bowtie skeleton width style

* fix bowtie skeleton width

* add native title based tooltip

---------

Co-authored-by: Benjamin Granados <[email protected]>

* [data]: Sync and finalise tooling data (#899)

* sync tooling data

* add tooling data validation workflow and fix JSONSchemaTool interface

* fix undefined error

* use corepack and yarn in workflow

* fix tooling data

* fix tooling data draft

* Added 2 last tools

---------

Co-authored-by: Benjamin Granados <[email protected]>

* [web-release-tooling]: Minor fixes web tooling page (#913)

* add /implementations to /tools redirects

* fix /tools sidebar dropdown scrollbar

* fix nav link does not reset filters

* fix redirect typo

* update yarn lock

* fix redirects

* move wild card redirect to last

* fix dependencies problem

---------

Co-authored-by: Benjamin Granados <[email protected]>

* Removing old data files

* update the implementers workflow

---------

Co-authored-by: Benjamin Granados <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Google Summer of Code related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants