Add proper tests. #9

beauby · 2016-11-20T21:52:02Z

No description provided.

houndci-bot · 2016-11-20T21:52:18Z

spec/requests/crud_spec.rb

@@ -0,0 +1,72 @@
+require 'rails_helper'


Missing frozen string literal comment.

houndci-bot · 2016-11-20T21:52:18Z

spec/dummy/db/migrate/20161120191133_create_tweets.rb

@@ -0,0 +1,11 @@
+class CreateTweets < ActiveRecord::Migration[5.0]


Missing frozen string literal comment.

houndci-bot · 2016-11-20T21:52:18Z

spec/spec_helper.rb

+
+# The settings below are suggested to provide a good initial experience
+# with RSpec, but feel free to customize to your heart's content.
+=begin


Do not use block comments.

houndci-bot · 2016-11-20T21:52:18Z

spec/spec_helper.rb

@@ -0,0 +1,101 @@
+require 'jsonapi/parser'
+
+# This file was generated by the `rails generate rspec:install` command. Conventionally, all


Line is too long. [92/80]

houndci-bot · 2016-11-20T21:52:18Z

spec/spec_helper.rb

@@ -0,0 +1,101 @@
+require 'jsonapi/parser'


Missing frozen string literal comment.

houndci-bot · 2016-11-20T21:52:18Z

spec/rails_helper.rb

+ENV['RAILS_ENV'] ||= 'test'
+require File.expand_path('../dummy/config/environment', __FILE__)
+# Prevent database truncation if the environment is production
+abort("The Rails environment is running in production mode!") if Rails.env.production?


Prefer single-quoted strings when you don't need string interpolation or special symbols.
Line is too long. [86/80]

houndci-bot · 2016-11-20T21:52:19Z

spec/rails_helper.rb

@@ -0,0 +1,57 @@
+# This file is copied to spec/ when you run 'rails generate rspec:install'


Missing frozen string literal comment.

houndci-bot · 2016-11-20T21:52:19Z

spec/dummy/db/schema.rb

+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+  end
+


Extra empty line detected at block body end.

houndci-bot · 2016-11-20T21:52:19Z

spec/dummy/db/schema.rb

+    t.string   "name"
+    t.string   "email"
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2016-11-20T21:52:19Z

spec/dummy/db/schema.rb

+  create_table "users", force: :cascade do |t|
+    t.string   "name"
+    t.string   "email"
+    t.datetime "created_at", null: false


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2016-11-20T21:52:19Z

spec/dummy/db/schema.rb

+
+  create_table "users", force: :cascade do |t|
+    t.string   "name"
+    t.string   "email"


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2016-11-20T21:52:19Z

spec/dummy/db/schema.rb

+  end
+
+  create_table "users", force: :cascade do |t|
+    t.string   "name"


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2016-11-20T21:52:20Z

spec/dummy/db/schema.rb

+    t.index ["parent_id"], name: "index_tweets_on_parent_id"
+  end
+
+  create_table "users", force: :cascade do |t|


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2016-11-20T21:52:20Z

spec/dummy/db/schema.rb

+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+    t.index ["author_id"], name: "index_tweets_on_author_id"
+    t.index ["parent_id"], name: "index_tweets_on_parent_id"


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2016-11-20T21:52:20Z

spec/dummy/db/schema.rb

+    t.text     "content"
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+    t.index ["author_id"], name: "index_tweets_on_author_id"


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2016-11-20T21:52:20Z

spec/dummy/db/schema.rb

+    t.integer  "author_id"
+    t.text     "content"
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2016-11-20T22:07:49Z

spec/dummy/config/initializers/new_framework_defaults.rb

+# Do not halt callback chains when a callback returns false. Previous versions had true.
+ActiveSupport.halt_callback_chains_on_return_false = false
+
+# Configure SSL options to enable HSTS with subdomains. Previous versions had false.


Line is too long. [84/80]

houndci-bot · 2016-11-20T22:07:50Z

spec/dummy/config/initializers/new_framework_defaults.rb

+# Require `belongs_to` associations by default. Previous versions had false.
+Rails.application.config.active_record.belongs_to_required_by_default = true
+
+# Do not halt callback chains when a callback returns false. Previous versions had true.


Line is too long. [88/80]

houndci-bot · 2016-11-20T22:07:50Z

spec/dummy/config/initializers/new_framework_defaults.rb

+Rails.application.config.action_controller.per_form_csrf_tokens = true
+
+# Enable origin-checking CSRF mitigation. Previous versions had false.
+Rails.application.config.action_controller.forgery_protection_origin_check = true


Line is too long. [81/80]

houndci-bot · 2016-11-20T22:07:50Z

spec/dummy/config/initializers/new_framework_defaults.rb

@@ -0,0 +1,24 @@
+# Be sure to restart your server when you modify this file.


Missing frozen string literal comment.

houndci-bot · 2016-11-20T22:07:50Z

spec/dummy/config/initializers/inflections.rb

@@ -0,0 +1,16 @@
+# Be sure to restart your server when you modify this file.


Missing frozen string literal comment.

houndci-bot · 2016-11-20T22:07:50Z

spec/dummy/config/initializers/session_store.rb

@@ -0,0 +1,3 @@
+# Be sure to restart your server when you modify this file.


Missing frozen string literal comment.

houndci-bot · 2016-11-20T22:07:51Z

spec/dummy/config/initializers/filter_parameter_logging.rb

@@ -0,0 +1,4 @@
+# Be sure to restart your server when you modify this file.


Missing frozen string literal comment.

houndci-bot · 2016-11-20T22:07:51Z

spec/dummy/config/initializers/mime_types.rb

@@ -0,0 +1,4 @@
+# Be sure to restart your server when you modify this file.


Missing frozen string literal comment.

houndci-bot · 2016-11-20T22:07:51Z

spec/dummy/config/initializers/backtrace_silencers.rb

+# You can add backtrace silencers for libraries that you're using but don't wish to see in your backtraces.
+# Rails.backtrace_cleaner.add_silencer { |line| line =~ /my_noisy_library/ }
+
+# You can also remove all the silencers if you're trying to debug a problem that might stem from framework code.


Line is too long. [112/80]

houndci-bot · 2016-11-20T22:07:51Z

spec/dummy/config/initializers/backtrace_silencers.rb

@@ -0,0 +1,7 @@
+# Be sure to restart your server when you modify this file.
+
+# You can add backtrace silencers for libraries that you're using but don't wish to see in your backtraces.


Line is too long. [107/80]

houndci-bot · 2016-11-20T22:07:51Z

spec/dummy/config/initializers/backtrace_silencers.rb

@@ -0,0 +1,7 @@
+# Be sure to restart your server when you modify this file.


Missing frozen string literal comment.

houndci-bot · 2016-11-20T22:07:51Z

spec/dummy/config/initializers/assets.rb

+# Rails.application.config.assets.paths << Emoji.images_path
+
+# Precompile additional assets.
+# application.js, application.css, and all non-JS/CSS in app/assets folder are already added.


Line is too long. [93/80]

houndci-bot · 2016-11-20T22:07:52Z

spec/dummy/config/initializers/assets.rb

@@ -0,0 +1,11 @@
+# Be sure to restart your server when you modify this file.


Missing frozen string literal comment.

houndci-bot · 2016-11-20T22:07:52Z

spec/dummy/config/environments/production.rb

+  # require 'syslog/logger'
+  # config.logger = ActiveSupport::TaggedLogging.new(Syslog::Logger.new 'app-name')
+
+  if ENV["RAILS_LOG_TO_STDOUT"].present?


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2016-11-20T22:07:52Z

spec/dummy/config/environments/production.rb

+
+  # Use a different logger for distributed setups.
+  # require 'syslog/logger'
+  # config.logger = ActiveSupport::TaggedLogging.new(Syslog::Logger.new 'app-name')


Line is too long. [83/80]

houndci-bot · 2016-11-20T22:07:52Z

spec/dummy/config/environments/production.rb

+  config.action_mailer.perform_caching = false
+
+  # Ignore bad email addresses and do not raise email delivery errors.
+  # Set this to true and configure the email server for immediate delivery to raise delivery errors.


Line is too long. [100/80]

houndci-bot · 2016-11-20T22:11:09Z

spec/dummy/db/migrate/20161120191438_create_users.rb

@@ -0,0 +1,10 @@
+class CreateUsers < ActiveRecord::Migration[5.0]


Missing frozen string literal comment.

houndci-bot · 2016-11-20T22:22:52Z

spec/dummy/db/schema.rb

+    t.integer  "parent_id"
+    t.integer  "author_id"
+    t.text     "content"
+    t.datetime "created_at", null: false


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2016-11-20T22:22:53Z

spec/dummy/db/schema.rb

+  create_table "tweets", force: :cascade do |t|
+    t.integer  "parent_id"
+    t.integer  "author_id"
+    t.text     "content"


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2016-11-20T22:22:53Z

spec/dummy/db/schema.rb

+
+  create_table "tweets", force: :cascade do |t|
+    t.integer  "parent_id"
+    t.integer  "author_id"


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2016-11-20T22:22:53Z

spec/dummy/db/schema.rb

+ActiveRecord::Schema.define(version: 20161120191438) do
+
+  create_table "tweets", force: :cascade do |t|
+    t.integer  "parent_id"


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2016-11-20T22:22:53Z

spec/dummy/db/schema.rb

+
+ActiveRecord::Schema.define(version: 20161120191438) do
+
+  create_table "tweets", force: :cascade do |t|


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2016-11-20T22:22:53Z

spec/dummy/db/schema.rb

+# It's strongly recommended that you check this file into your version control system.
+
+ActiveRecord::Schema.define(version: 20161120191438) do
+


Extra empty line detected at block body beginning.

houndci-bot reviewed Nov 20, 2016

View reviewed changes

spec/requests/crud_spec.rb

@@ -0,0 +1,72 @@

require 'rails_helper'

Copy link

houndci-bot Nov 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing frozen string literal comment.

houndci-bot reviewed Nov 20, 2016

View reviewed changes

spec/spec_helper.rb

@@ -0,0 +1,101 @@

require 'jsonapi/parser'

Copy link

houndci-bot Nov 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing frozen string literal comment.

houndci-bot reviewed Nov 20, 2016

View reviewed changes

beauby force-pushed the proper-tests branch from 8b5c41c to acf7d62 Compare November 20, 2016 22:07

houndci-bot reviewed Nov 20, 2016

View reviewed changes

beauby force-pushed the proper-tests branch from acf7d62 to 0e83c41 Compare November 20, 2016 22:10

houndci-bot reviewed Nov 20, 2016

View reviewed changes

beauby force-pushed the proper-tests branch 2 times, most recently from 385b6d3 to b02a63f Compare November 20, 2016 22:22

houndci-bot reviewed Nov 20, 2016

View reviewed changes

beauby force-pushed the proper-tests branch 3 times, most recently from 248738a to 9f8d16f Compare November 20, 2016 23:06

beauby added this to the 0.2 milestone Nov 21, 2016

Add test app.

053f232

beauby force-pushed the proper-tests branch from 9f8d16f to 053f232 Compare November 21, 2016 03:32

beauby merged commit 599bfd8 into master Nov 21, 2016

beauby deleted the proper-tests branch November 21, 2016 07:29

		@@ -0,0 +1,11 @@
		class CreateTweets < ActiveRecord::Migration[5.0]

		@@ -0,0 +1,101 @@
		require 'jsonapi/parser'

		# This file was generated by the `rails generate rspec:install` command. Conventionally, all

		@@ -0,0 +1,57 @@
		# This file is copied to spec/ when you run 'rails generate rspec:install'

		@@ -0,0 +1,24 @@
		# Be sure to restart your server when you modify this file.

		@@ -0,0 +1,16 @@
		# Be sure to restart your server when you modify this file.

		@@ -0,0 +1,3 @@
		# Be sure to restart your server when you modify this file.

		@@ -0,0 +1,4 @@
		# Be sure to restart your server when you modify this file.

		@@ -0,0 +1,7 @@
		# Be sure to restart your server when you modify this file.

		# You can add backtrace silencers for libraries that you're using but don't wish to see in your backtraces.

		@@ -0,0 +1,10 @@
		class CreateUsers < ActiveRecord::Migration[5.0]


		ActiveRecord::Schema.define(version: 20161120191438) do

		create_table "tweets", force: :cascade do \|t\|

		# It's strongly recommended that you check this file into your version control system.

		ActiveRecord::Schema.define(version: 20161120191438) do

Add proper tests. #9

Add proper tests. #9

Uh oh!

Conversation

beauby commented Nov 20, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!