Skip to content

Remove PHPDocumentor & change travis platform for hhvm tests #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2017
Merged

Remove PHPDocumentor & change travis platform for hhvm tests #429

merged 2 commits into from
Jun 5, 2017

Conversation

erayd
Copy link
Contributor

@erayd erayd commented Jun 2, 2017

What

  • Remove phpdocumentor from dev-time dependencies
  • Change the travis test platform for hhvm to trusty

Why

  • PHPDocumentor isn't actually called anywhere in our code, and is causing numerous dependency resolution failures. Something upstream has been rather active with causing conflicts lately, and PHPDocumentor development is slow (last release over a year ago) and pulls in a ton of ancient stuff.
  • We should probably replace it with another phpdoc documentation generator at some point - ideally at the same time as we overhaul the documentation in general - but for now, this issue needs a quick fix, and removing the PHPDocumentor requirement feels like the most sensible course of action here.
  • Travis no longer supports HHVM tests on Ubuntu Precise (the current stable test platform), so switching to trusty is required in order to maintain full platform coverage in the testsuite.

@erayd erayd mentioned this pull request Jun 2, 2017
Merged
@krishnaprasadmg krishnaprasadmg mentioned this pull request Jun 2, 2017
Closed
@shmax
Copy link
Collaborator

shmax commented Jun 5, 2017

LGTM

bighappyface
bighappyface approved these changes Jun 5, 2017
View reviewed changes
Copy link
Collaborator

@bighappyface bighappyface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bighappyface bighappyface merged commit 6407baa into jsonrainbow:6.0.0-dev Jun 5, 2017
erayd added a commit to erayd/json-schema that referenced this pull request Jun 5, 2017
@erayd
Remove PHPDocumentor & change travis platform for hhvm tests (jsonrai…
14973ed 
…nbow#429)

* Remove dev-time dependency on phpdocumentor due to resolution headaches

* Switch distro for hhvm testing to trusty (precise now unsupported)
@erayd erayd mentioned this pull request Jun 5, 2017
Merged
bighappyface pushed a commit that referenced this pull request Jun 5, 2017
@erayd @bighappyface
Backports for 5.2.2 (#431)
2a42039 
* Remove PHPDocumentor & change travis platform for hhvm tests (#429)

* Remove dev-time dependency on phpdocumentor due to resolution headaches

* Switch distro for hhvm testing to trusty (precise now unsupported)

* Bugfix for #424 - add '?' for query string (#425)

Note that this bugfix will cause empty query strings to be dropped (e.g.
http://example.com?#blue becomes http://example.com#blue). This is
because the '?' character is deliberately not captured as part of the
query string, and the testsuite expects to be able to pass an empty
query string and *not* have the '?' added for that case.
@erayd erayd mentioned this pull request Jun 8, 2017
Closed
@erayd erayd deleted the phpdoc-and-hhvm branch June 8, 2017 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bighappyface bighappyface bighappyface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erayd @shmax @bighappyface