Skip to content

Added property name in draft-3 required error #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Added property name in draft-3 required error #432

merged 1 commit into from
Jun 6, 2017

Conversation

sunspikes
Copy link
Contributor

In case of required error with draft-3, the error message is missing property names. (Similar to #91)

Creating a new PR against the updated master.

Copy link
Contributor

@erayd erayd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please close this PR - it's a duplicate of #430.

#430 needs to be rebased to incorporate new changes - that does not mean opening a new PR, it just means running git rebase 6.0.0-dev on your branch, then pushing the result.

@sunspikes
Copy link
Contributor Author

@erayd Actually as i mentioned, after creating the PR #430 I've deleted my branch (As you can see in the PR it shows unknown repository). Not sure if i can check out the PR rebase it and push it again without having my original branch.

@erayd
Copy link
Contributor

erayd commented Jun 6, 2017

@sunspikes I missed that comment - think I typed my reply before yours loaded for me. Noting that, let's just go with this PR.

For future reference, if you have an open PR, don't delete the branch it's attached to until after it's been merged ;-). If you accidentally delete your branch, GitHub allows you to restore it from the PR (there's a button at the bottom of the PR for this).

Copy link
Collaborator

@bighappyface bighappyface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bighappyface bighappyface merged commit 024f3d8 into jsonrainbow:6.0.0-dev Jun 6, 2017
erayd pushed a commit to erayd/json-schema that referenced this pull request Jun 6, 2017
Backport modifications:
 * Change error syntax to use pre-6.0.0 API
erayd pushed a commit to erayd/json-schema that referenced this pull request Jun 6, 2017
Backport modifications:
 * Change error syntax to use the old pre-6.0.0 API
@erayd erayd mentioned this pull request Jun 8, 2017
bighappyface pushed a commit that referenced this pull request Jun 23, 2017
Backport modifications:
 * Change error syntax to use the old pre-6.0.0 API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants