Fix: Remove unused argument #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
commented
Dec 30, 2017
| @@ -1,7 +1,7 @@ | |||
| <?php | |||
|
|
|||
| $finder = new PhpCsFixer\Finder(); | |||
| $config = new PhpCsFixer\Config('json-schema', 'json-schema style guide'); | |||
There was a problem hiding this comment.
The $description argument was removed in PHP-CS-Fixer/PHP-CS-Fixer#2244.
There was a problem hiding this comment.
Why have you also removed $name, when only $description has been deprecated?
localheinz
commented
Dec 31, 2017
| @@ -1,7 +1,7 @@ | |||
| <?php | |||
|
|
|||
| $finder = new PhpCsFixer\Finder(); | |||
| $config = new PhpCsFixer\Config('json-schema', 'json-schema style guide'); | |||
| $config = new PhpCsFixer\Config('json-schema'); | |||
erayd
approved these changes
Dec 31, 2017
| @@ -1,7 +1,7 @@ | |||
| <?php | |||
|
|
|||
| $finder = new PhpCsFixer\Finder(); | |||
| $config = new PhpCsFixer\Config('json-schema', 'json-schema style guide'); | |||
| $config = new PhpCsFixer\Config('json-schema'); | |||
There was a problem hiding this comment.
My mistake, sorry! I looked at the diff and thought I saw the whole line removed.
|
Thank you, @bighappyface and @erayd! |
erayd
pushed a commit
to erayd/json-schema
that referenced
this pull request
Feb 14, 2018
Fix: Remove unused argument
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Somewhat related to #477.