Skip to content

Fix: No need to specify path to bin directory #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2017
Merged

Fix: No need to specify path to bin directory #479

merged 1 commit into from
Dec 31, 2017

Conversation

localheinz
Copy link
Contributor

This PR

  • removes vendor/bin from scripts defined in composer.json

💁‍♂️ For reference, see https://getcomposer.org/doc/articles/scripts.md#writing-custom-commands:

Note: Before executing scripts, Composer's bin-dir is temporarily pushed on top of the PATH environment variable so that binaries of dependencies are easily accessible. In this example no matter if the phpunit binary is actually in vendor/bin/phpunit or bin/phpunit it will be found and executed.

@bighappyface bighappyface merged commit bb4f2e4 into jsonrainbow:master Dec 31, 2017
@localheinz localheinz deleted the fix/script branch December 31, 2017 08:32
@localheinz
Copy link
Contributor Author

Thank you, @bighappyface and @erayd!

erayd pushed a commit to erayd/json-schema that referenced this pull request Feb 14, 2018
@bighappyface @erayd
Merge pull request jsonrainbow#479 from localheinz/fix/script
ce95363 
Fix: No need to specify path to bin directory
@erayd erayd mentioned this pull request Feb 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erayd erayd erayd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@localheinz @erayd @bighappyface