Tests on php 7.3 #563
Closed
Tests on php 7.3 #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erayd
requested changes
Feb 4, 2019
There was a problem hiding this comment.
Please resolve the php-cs-fixer conflict. If we're going to be adding support for 7.3, then we'll need a newer pinned version.
Note that it's pinned to prevent newer versions making undesired logical changes to the code without warning, as we've had issues with this in the past. If you upgrade it, please be very careful to ensure that this doesn't happen with the upgraded version.
|
@erayd Thanks, I will do it |
SignpostMarv
added a commit
to SignpostMarv/json-schema
that referenced
this pull request
Jun 2, 2019
Merged
erayd
pushed a commit
that referenced
this pull request
Jun 3, 2019
* Tests on php 7.3 * bumping php-cs-fixer version as per comment from @erayd on #563 * turning yoda style off to preserve previous behaviour * some EOL versions of php require an older version of php-cs-fixer * attempting to normalise behaviour with php-cs-fixer 2.2 * attempt separate run of php 7.0 to avoid having xdebug loaded when running php-cs-fixer
|
Superseded by #575. |
erayd
pushed a commit
to erayd/json-schema
that referenced
this pull request
Sep 25, 2019
* Tests on php 7.3 * bumping php-cs-fixer version as per comment from @erayd on jsonrainbow#563 * turning yoda style off to preserve previous behaviour * some EOL versions of php require an older version of php-cs-fixer * attempting to normalise behaviour with php-cs-fixer 2.2 * attempt separate run of php 7.0 to avoid having xdebug loaded when running php-cs-fixer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.