Fix travis PHP 5.4 and 5.5 #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erayd
approved these changes
Sep 23, 2019
|
Have just reversed the merge for this sorry - it modifies the 5.x.x branch, and I didn't initially notice this. Excepting very rare situations where a patch affects only the 5.x.x branch, we don't allow that - patches must apply in the master branch first, and are then backported via another PR (helps keep everything very consistent). I will roll a backport release for you this week which includes #583. |
|
No questions about this PR. I'm more concerned with #589 if you can have a look at it. |
|
@sanmai I have merged that one - thank you for catching that; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #583