Fix a case of 2 invalid oneOf were considered valid #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gwagner
commented
Feb 25, 2014
gwagner
commented
- When using oneOf, one of the schemas should be considered valid for things to be successful. The old logic would take a schema (that could have had an error) and evaluate against a clean object that could have also contained an error (meaning the logic would assume no error existed)
* When using oneOf, one of the schemas should be considered valid for things to be successful. The old logic would take a schema (that could have had an error) and evaluate against a clean object that could have also contained an error (meaning the logic would assume no error existed)
| $matchedSchemas = 0; | ||
| $startErrors = $this->getErrors(); | ||
| foreach ($schema->oneOf as $oneOf) { | ||
| $initErrors = $this->getErrors(); | ||
| $this->errors = []; |
There was a problem hiding this comment.
Could you change the [] to array() for PHP 5.3 support?
Fix the php < 5.4 compatability
|
Should now be fixed, i thought i had updated all of those |
| @@ -230,17 +230,28 @@ protected function validateOfProperties($value, $schema, $path, $i = "") | |||
| } | |||
|
|
|||
| if (isset($schema->oneOf)) { | |||
| $allErrors = []; | |||
There was a problem hiding this comment.
Sorry, didn't catch this one before. Could you change this to array(), too? Then we should be all good for merge.
Doh, missed another php < 5.4 compatibility bug
justinrainbow
added a commit
that referenced
this pull request
Mar 3, 2014
Fix a case of 2 invalid oneOf were considered valid
hakre
pushed a commit
to hakre/json-schema
that referenced
this pull request
Mar 26, 2015
Fix a case of 2 invalid oneOf were considered valid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.