Skip to content

v6.10.1 breaks v6.10.0 builds (related to jsx-indent) #1117

Closed
singapore/lint-condo
#262
@diegohaz

Description

@diegohaz

Error:

103:11  error  Expected indentation of 8 space characters but found 10  react/jsx-indent

Code from 103:11:
https://github.com/diegohaz/arc/blob/84ef1227b18f3d80ac6a297345ccc007ab191015/src/components/molecules/Modal/index.js#L103

On v6.10.0 it doesn't occur.

Activity

ljharb

ljharb commented on Mar 19, 2017

@ljharb
Member

This also is breaking react-dates react-dates/react-dates#383

yannickcr

yannickcr commented on Mar 19, 2017

@yannickcr
Member

Looking at it.

ljharb

ljharb commented on Mar 19, 2017

@ljharb
Member

@yannickcr i'm afraid this still isn't fixed.

This code is still warning on jsx-indent, newly in 6.10+.

reopened this on Mar 19, 2017
ljharb

ljharb commented on Mar 20, 2017

@ljharb
Member

(there's a number of other examples in that repo; clone at this sha and run npm install && npm run lint to see the errors)

yannickcr

yannickcr commented on Mar 20, 2017

@yannickcr
Member

Crap, you're right. Seems to be another issue with multi-line tags. I'll made another patch release shortly. but there is a good chance it will be done tomorrow (it's getting late here).

81 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @yannickcr@ljharb@jesstelford@atkinchris@freak3dot

    Issue actions

      v6.10.1 breaks v6.10.0 builds (related to jsx-indent) · Issue #1117 · jsx-eslint/eslint-plugin-react