Skip to content

[Bug]: require-default-props JSON schema is incorrect #3604

Closed
@controversial

Description

@controversial
Contributor

(coming from eslint-types/eslint-define-config#213)

The JSON schema for the require-default-props rule incorrectly wraps the enum in an allow, resulting in a JSON schema that matches an object instead of a JSON schema that matches strings.

classes: {
allow: {
enum: ['defaultProps', 'ignore'],
},
},
functions: {
allow: {
enum: ['defaultArguments', 'defaultProps', 'ignore'],
},
},

The downstream result of the incorrect schema:
image

Here’s an example of another rule whose JSON schema is correctly written.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @controversial

      Issue actions

        [Bug]: `require-default-props` JSON schema is incorrect · Issue #3604 · jsx-eslint/eslint-plugin-react