Closed
Description
Is there an existing issue for this?
- I have searched the existing issues and my issue is uniqueMy issue appears in the command-line and not only in the text editor
Description Overview
Source:
In the currently published version on npm (7.37.0), the new type declarations added in #3830 are missing. You can browse the published files here.
Expected Behavior
There should be a index.d.ts
in the published package.
Also, package.json
should have a "types" field.
"main": "index.js",
"types": "index.d.ts",
eslint-plugin-react version
v7.37.0
eslint version
NA
node version
NA
Activity
ljharb commentedon Oct 1, 2024
@voxpelli in your original PR, you mentioned that the d.ts file will be preferred and the jsdoc comments ignored when present - does that impact adding the
types
field?(i already have a fix locally for not npmignoring the d.ts files)
voxpelli commentedon Oct 1, 2024
@ljharb the
"types"
field defaults toindex.d.ts
when not explicitly set as far as I remember, so it shouldn't actually be needed in this case, but it also shouldn't do much harmljharb commentedon Oct 1, 2024
In that case it's just the npmignore thing for this issue (the failure of the type building in the publish workflow is separate)
[meta] do not npmignore `d.ts` files
chore(deps): update dependency eslint-plugin-react to v7.37.1
fix(deps): update dependency eslint-plugin-react to v7.37.1
chore(deps): update dependency eslint-plugin-react to v7.37.1
chore(deps): update dependency eslint-plugin-react to v7.37.1
chore(deps): update dependency eslint-plugin-react to v7.37.1
fix(deps): update dependency eslint-plugin-react to v7.37.1
26 remaining items