Skip to content

fix(sort-prop-types): correct guard against falsy #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2018
Merged

fix(sort-prop-types): correct guard against falsy #1842

merged 1 commit into from
Jul 21, 2018

Conversation

ferhatelmas
Copy link
Contributor

No description provided.

ljharb
ljharb requested changes Jun 23, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a test case - it's not clear why this is wrong.

@finnp finnp mentioned this pull request Jul 21, 2018
Merged
@ljharb ljharb force-pushed the sort-prop-types-guard branch from 32cae68 to 6b179ed Compare July 21, 2018 19:09
ljharb
ljharb approved these changes Jul 21, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a test case in #1891; this PR will be merged as part of that one.

@ljharb ljharb merged commit 6b179ed into jsx-eslint:master Jul 21, 2018
@ljharb ljharb added the bug label Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferhatelmas @ljharb