Add new dom-elements-style-is-object rule (Fixes #715)

[petersendidit]

Fixes #715

[lencioni]

I think we want to wait to enable this in the recommended configuration until the next major version bump, since doing so may end up breaking people's builds.

[yannickcr]

Great! Can you fix the issues raised by @lencioni?

Also I'm not really a fan of the rule name: too long, should start by jsx- like the other rules.

jsx-style-object? Any other idea?

[ljharb]

It shouldn't have jsx since it should apply to createElement DOM elements too.

[petersendidit]

Yea been hoping to get back to fixing up this rule. Hoping I can do it sometime this weekend.

Yes the name is long but I think it accurately describes the rule.

[petersendidit]

Checking that the style object values are stings has been pulled out and addressed the other comments.

[yannickcr]

@ljharb A lot of current JSX rules can also apply to createElement. So even if it also apply to createElement I still think it should be prefixed by jsx-, just by consistency with the other rules.

[ljharb]

@yannickcr hm, I feel the opposite - that those rules should be renamed to not have jsx unless that's the only thing they apply to.

[petersendidit]

So what is the decision on the name? Are we going with jsx-style-object or are we sticking with the longer name?

[ljharb]

I don't care about the length; style-prop-object would be fine with me too. I just think that jsx- should be reserved only for things that can only apply to jsx.

[yannickcr]

Sorry for the delay.

those rules should be renamed to not have jsx unless that's the only thing they apply to

Yeah, in fact the jsx- rules should only be styling rules for JSX since the other ones can apply to creactElement too. A rename would be the solution but I'm not really a fan of renaming rules since it introduces a breaking change for almost no added value 😐. But that's another discussion 😉

I'm ok with style-prop-object 👍

[petersendidit]

Renamed the rule. Let me know if there is anything else left to do.

[yannickcr]

Merged. Thank you!

[antoinerousseau]

does not work if i'm using componentWillReceiveProps's first argument (next props)