Skip to content

Add autofix for jsx-first-prop-new-line #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

shioju
Copy link

@shioju shioju commented Nov 2, 2016

No description provided.

snowypowers and others added 2 commits November 2, 2016 11:09

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Fixes #1

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
- Change rule to only look at the first prop using Array.some
  instead of Array.forEach and returning true
- Update documentation
@ljharb
Copy link
Member

ljharb commented Nov 2, 2016

This appears to be based on #886?

enum: ['always', 'never', 'multiline', 'multiline-multiprop']
},
{
oneOf: [{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent should not be passed separately - it should just use 4 spaces (the indent default) and the individual indent rules should handle autofixing them.

@shioju
Copy link
Author

shioju commented Nov 2, 2016

there's another PR for the same autofix

@shioju shioju closed this Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants