Skip to content

allow Nullable.<void> #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 1, 2014
Merged

allow Nullable.<void> #307

merged 4 commits into from
Apr 1, 2014

Conversation

nyuichi
Copy link
Member

@nyuichi nyuichi commented Mar 28, 2014

Please refer to the discussion on #306.

@nyuichi nyuichi mentioned this pull request Mar 28, 2014
Merged
@gfx
Copy link
Member

gfx commented Mar 31, 2014

👀

@nyuichi
Copy link
Member Author

nyuichi commented Mar 31, 2014

See also #303, please.

@kazuho
Copy link
Member

kazuho commented Apr 1, 2014

@wasabiz
Thank you for the PR. As discussed, please modify the tests to actually use the variable, and merge to master.

nyuichi added a commit that referenced this pull request Apr 1, 2014
@nyuichi
Merge pull request #307 from jsx/wasabiz/feature/allow-nullable-void
6704e4e 
allow Nullable.<void>
@nyuichi nyuichi merged commit 6704e4e into master Apr 1, 2014
@kazuho
Copy link
Member

kazuho commented Apr 1, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nyuichi @gfx @kazuho