profile server as bin/jsx-profile-server #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$HOME/.jsx/profile) (cherry-picked from 3f280cd)
|
ToDo: fix test error in |
This was referenced Apr 8, 2014
…ot). * fix unit test * Add parameter to specify profile storing directory (for test). * Remove debug console.log
|
Sent fix |
|
Thank you for the fix! Did some nitpicks, will merge to master when test passes. It would be great if you could from now on split independent changes to different commits instead of squashing them into one and listing them in the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be easier for users if the profile server becomes a dedicated command.
note: the work was originally part of PR #309