Change error handling #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=========================================
- Coverage 0.75% 0.74% -0.02%
=========================================
Files 4 4
Lines 132 134 +2
=========================================
Hits 1 1
- Misses 131 133 +2
Continue to review full report at Codecov.
|
ZacLN
approved these changes
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how we handle errors.
The new story is: if a handler function wants to return a JSON RPC error response, it should not throw an error, but just return an instance of
JSONRPCError.That allows us to actually throw
JSONRPCErrorif a request returns an error.The current implementation hides error returns from the dreaded config requests, with this PR things should work better.