Fix console launcher's --uid option
#4589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, unique id selectors weren't
included in the list of explicit selectors - which
resulted a false error message:
Please specify an explicit selector option or
use `--scan-class-path` or `--scan-modules`
Fixes #4587
marcphilipp
reviewed
May 27, 2025
platform-tests/src/test/java/org/junit/platform/console/tasks/DiscoveryRequestCreatorTests.java
Outdated
Show resolved
Hide resolved
…DiscoveryRequestCreatorTests.java Co-authored-by: Marc Philipp <[email protected]>
marcphilipp
requested changes
May 27, 2025
| * ❓ | ||
| * Fix support of `--uid`/`--select-unique-id` options in the console launcher. |
There was a problem hiding this comment.
This should go to the 5.13.0 release notes
marcphilipp
approved these changes
May 27, 2025
marcphilipp
added a commit
that referenced
this pull request
May 27, 2025
Prior to this commit, unique id selectors weren't
included in the list of explicit selectors - which
resulted a false error message:
```
Please specify an explicit selector option or
use `--scan-class-path` or `--scan-modules`
```
Fixes #4587
---------
Co-authored-by: Marc Philipp <[email protected]>
(cherry picked from commit fa3c065)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Prior to this change, unique id selectors weren't included in the list of explicit selectors - which resulted in a confusing error message:
Note that
--select uid:[...]was not affected by this bug.Fixes #4587
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations