@Ignore not taking effect when used on an overriden test method

[triceo]

When I have a test in super class which I then override in subclass and add the Ignore annotation to this overriden test, the test is run anyway. (Not ignored.)

Reproducer for the issue can be found here:
https://github.com/triceo/junit/commit/14e5d37f09d7c822d93a172481796524017735ee

[kcooney]

The method in the subclass is not annotated with @test

[triceo]

If the method didn't execute at all, because it's not a @test, I would understand. However, the method executes (even though it's not annotated as @test), and thus @ignore should in my opinion apply as well.

[kcooney]

The method is considered a test because the base class method is annotated
with @test (so the base class version of the method is examined). The base
class method is not annotated with @ignore so it is not ignored.

[dsaff]

The subclass method does need to be annotated with "@test" in order to be considered to override the superclass method for JUnit's purposes (we basically have to re-implement "overriding" for our odd reflection-based execution model.)

I think this is probably a good rule to enforce, but I can understand the confusion it causes in this case. I might consider adding a validation check that would flag an error if a superclass method with @test matches the name of a subclass method without @test. Would that have solved your problem?

[triceo]

Yes, that would've worked as well.

[junit-builds]

JUnit 4 is now in maintenance mode.

At this point, only critical bugs and security issues will be fixed.

The team has therefore decided to close this issue.