-
Notifications
You must be signed in to change notification settings - Fork 958
Custom widget persistence #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jdfreder
merged 7 commits into
jupyter-widgets:master
from
SylvainCorlay:custom_widget_persistence
Jun 19, 2015
Merged
Custom widget persistence #58
jdfreder
merged 7 commits into
jupyter-widgets:master
from
SylvainCorlay:custom_widget_persistence
Jun 19, 2015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FYI, the first three hunks and the last hunk are just whitespace changes. Real changes are just lines 417-465. |
At a glance, this looks okay. @jdfreder, since you wrote the original code, can you take a look at this too? Thanks! |
Thanks @SylvainCorlay ! |
minrk
added a commit
to ipython/ipython
that referenced
this pull request
Jun 21, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
resolved-locked
Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
Foobar
is a custom widget that has a model defined in a requirejs module, specified in the_model_module
widget attribute, then something likeHBox([Foobar()])
won't survive a page reload.However,
Foobar()
alone does persist when it is not a child of a container.In short, custom widgets having custom models don't persist when they are children other widgets.
The symptom in the js console is the
load_class
complaining thatundefined is not in the registry
._view_name
and_view_module
has not yet been set in the model.Hence I changed the widget persistence mechanism, to first fetch the states of all the persisted models before instantiating any view.
Besides, the code is quite simpler, and it significantly reduces the line count.