Save changes should only save if comm is live #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense. |
There was a problem hiding this comment.
Sorry for the white space changes. This is the relevant change.
minrk
added a commit
that referenced
this pull request
Jun 20, 2015
Save changes should only save if comm is live
minrk
added a commit
to ipython/ipython
that referenced
this pull request
Jun 20, 2015
github-actions
bot
added
the
resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a notebook, run
then save the notebook and restart the kernel. The red broken link appears in the corner. However, when moving the slider, the back-end still receives messages and complains that "no such comm exists".
With this change,
save_changesbecomes a no-op in case of a dead comm.