Skip to content

Dropping six. #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SylvainCorlay opened this issue Jan 4, 2019 · 3 comments
Closed

Dropping six. #78

SylvainCorlay opened this issue Jan 4, 2019 · 3 comments
Labels
Enhancement New feature or request

Comments

@SylvainCorlay
Copy link
Member

It seems that if py::exec get fixed (with respect to calling other functions defined in the same call), we should be able to

  • drop the custom six-based exec function.
  • drop the workaround due to the extra function in the traceback.

Also, six is used for selecting between PY3 and PY2 in is_complete_request.

@SylvainCorlay SylvainCorlay added the Enhancement New feature or request label Jan 4, 2019
@martinRenou
Copy link
Member

pybind/pybind11#1654

@martinRenou
Copy link
Member

The workaround when using py::exec would be to add a __builtins__ key to the globals argument containing the content of the builtins module if it's not already there. And in the case of xis_complete, we should use the same dict for globals and locals.

@martinRenou
Copy link
Member

Fixed

DerThorsten pushed a commit to DerThorsten/xeus-python that referenced this issue Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants