This repository was archived by the owner on Oct 26, 2019. It is now read-only.
Fix problems from #168 #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't pass all request headers to /api/kernels to avoid ping-ponging requests when Host/Origin are unexpected * Fix random test failures by stubbing request.Request so that async callbacks we don't care about never happen * Fix integration test breakage: integration-test requires etc/notebooks for the docker build so we can't ignore it (c) Copyright IBM Corp. 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping-ponging requests when Host/Origin are unexpected
async callbacks we don't care about never happen
etc/notebooks for the docker build so we can't ignore it