Skip to content

Conversation

romainx
Copy link
Collaborator

@romainx romainx commented Jan 30, 2020

Bump version of R packages in datascience-notebook and all-spark-notebook focusing mainly on R Base 3.6.2 and Sparklyr 1.1.

Notes:

  • I've not intentionally updated r-notebook since it's deprecated -> [WIP] Deprecate pyspark-notebook, r-notebook, Mesos support #693
  • I do not know why r-sparklyr is installed in the datascience-notebook since Spark is not installed. I think it could be removed however I've not done it yet, I will create a dedicated issue for that.
library(sparklyr)
sc <- spark_connect(master = "local")

# Error in spark_install_find(version, hadoop_version, latest = FALSE, hint = TRUE): Spark version not installed. To install, use spark_install()

Makefile

Also added two new targets in the Makefile that I find handy to quick debug and check in the images

  • run: run a bash in interactive mode in a stack
  • run-sudo: run a bash in interactive mode as root in a stack

So for example

$ make run/all-spark-notebook
docker run -it --rm jupyter/all-spark-notebook bash

jovyan@454192dd1836:~$ 

$ make run-sudo/all-spark-notebook
docker run -it --rm -u root jupyter/all-spark-notebook bash

root@09a440ff22ff:~# 

PS: @parente I've read that you are searching for new maintainers. If it's still the case, I will be happy to help :-).

@romainx romainx requested a review from parente February 6, 2020 10:03
Copy link
Member

@parente parente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates @romainx. 🎈

Thanks also for the offer to help out maintaining these images. Sending PRs like this one to keep packages up to date is a fine way to get started. Help responding to issues would also be greatly appreciated. Many are questions addressed by documentation, or lack of documentation which should be created. Shepherding pull requests from others members of the community into recipes in the documentation, external stacks, or changes to these images is also invaluable and more of a time commitment.

As your involvement grows, we can grant you additional permissions in the repo to triage issues and merge PRs. jupyter/nbviewer#893 is an example of that in action.

@parente parente merged commit 36bce75 into jupyter:master Feb 8, 2020
@romainx
Copy link
Collaborator Author

romainx commented Feb 8, 2020

Thanks @parente. I greatly appreciate that you took the time to write this message.
I will be happy to follow your advices and contribute more and more to this project.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants