Pin pandas to version 1.5.3 to all spark images
#1925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@mathbunnyru do you understand this? :) |
mathbunnyru
reviewed
Jun 23, 2023
mathbunnyru
reviewed
Jun 23, 2023
mathbunnyru
reviewed
Jun 23, 2023
mathbunnyru
reviewed
Jun 23, 2023
mathbunnyru
requested changes
Jun 24, 2023
Co-authored-by: Ayaz Salikhov <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Ayaz Salikhov <[email protected]>
for more information, see https://pre-commit.ci
mathbunnyru
approved these changes
Jun 24, 2023
|
I think that we will see Apache Spark 4.0.0 in jan. or feb. 2024 and then we can remove this. |
Great, thanks. |
|
The error is for cache? |
No, we need to add a new exception here: https://github.com/jupyter/docker-stacks/blob/main/tests/base-notebook/test_packages.py#L67 |
|
hmm.. ok, so it just to add pandas to that list? |
mathbunnyru
reviewed
Jun 26, 2023
for more information, see https://pre-commit.ci
mathbunnyru
reviewed
Jun 26, 2023
|
@bjornjorgensen thank you! |
kentwait
pushed a commit
to kentwait/docker-stacks
that referenced
this pull request
Aug 3, 2023
* 1. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add note * typo * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove test * >=1.5.3 and <2.0.0 * update test * Update pyspark-notebook/Dockerfile Co-authored-by: Ayaz Salikhov <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update pyspark-notebook/Dockerfile Co-authored-by: Ayaz Salikhov <[email protected]> * move test to file * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add pandas to EXCLUDED_PACKAGES * add 1.5.3,<2.0.0 and sort list * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add ' * "pandas[version='>" * Rename test_pandas_version.py to unit_pandas_version.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ayaz Salikhov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This will install
pandasversion 1.5.3 for all spark images.Spark have a module called
pandas API on spark, this module usespandasfor many tasks.Apache spark have decided not to upgrade
pandas API on sparkto version 2.0 before Apache spark 4.0https://lists.apache.org/thread/jbxrpf81flr6rk1poj9mqjyl8p34ro6w
Issue ticket if applicable
Fix: #1924
Checklist (especially for first-time contributors)