Skip to content

Use async generator backport only on old python #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 13, 2021
Merged

Use async generator backport only on old python #154

merged 4 commits into from
Aug 13, 2021

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Aug 12, 2021 •
edited
Loading

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 12, 2021

mypy still complains:

  mypy run-test-pre: PYTHONHASHSEED='0'
  mypy run-test: commands[0] | mypy nbclient/client.py nbclient/exceptions.py nbclient/__init__.py nbclient/jsonutil.py nbclient/output_widget.py nbclient/util.py nbclient/_version.py
  nbclient/client.py:13: error: Name "asynccontextmanager" already defined (possibly by an import)
  Found 1 error in 1 file (checked 7 source files)
  ERROR: InvocationError for command /home/runner/work/nbclient/nbclient/.tox/mypy/bin/mypy nbclient/client.py nbclient/exceptions.py nbclient/__init__.py nbclient/jsonutil.py

Please advise how to mollify mypy or fix directly.

davidbrochart
davidbrochart reviewed Aug 13, 2021
View reviewed changes
Copy link
Member

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mkoeppe, I think we should just ignore the mypy check for the asynccontextmanager import.

@davidbrochart davidbrochart merged commit 61fd479 into jupyter:master Aug 13, 2021
@davidbrochart
Copy link
Member

Thanks!

@blink1073 blink1073 added the bug Something isn't working label Aug 13, 2021
@mkoeppe mkoeppe mentioned this pull request Nov 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbrochart davidbrochart davidbrochart left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't rely on backport package async_generator for python >= 3.7
3 participants
@mkoeppe @davidbrochart @blink1073