Adding comm_info method to kernel #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainCorlay
force-pushed
the
comm_list_shell_message
branch
from
b20911d to
6a8de03
Compare
SylvainCorlay
changed the title
SylvainCorlay
force-pushed
the
comm_list_shell_message
branch
2 times, most recently
from
151205f to
529dd04
Compare
SylvainCorlay
force-pushed
the
comm_list_shell_message
branch
from
529dd04 to
6b37de9
Compare
SylvainCorlay
force-pushed
the
comm_list_shell_message
branch
2 times, most recently
from
8221e00 to
99c830b
Compare
SylvainCorlay
force-pushed
the
comm_list_shell_message
branch
from
99c830b to
a3fa53f
Compare
|
Rebased. I guess that we would want to make notebook depend on the next release of |
minrk
changed the title
minrk
added a commit
that referenced
this pull request
Sep 8, 2015
Adding comm_info method to kernel
|
Since the notebook doesn't strictly depend on any kernel, that won't make sense. It also doesn't use the jupyter_client Python API, so that also won't be relevant here. This method is probably going to have to be allowed to be undefined on kernels for notebook 4.x. |
|
Changes Unknown when pulling a3fa53f on SylvainCorlay:comm_list_shell_message into ** on jupyter:master**. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on jupyter/jupyter_client#34 and ipython/ipykernel#25.