-
Notifications
You must be signed in to change notification settings - Fork 13
Updated CLI steps to avoid Drupal installation errors #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things to smooth things out.
Thanks @rfay, I've accepted your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked through it again :) Another round of suggestions. We need to get the add-on working though with yarn, see
Different approach (I hadn't read this PR closely and my solution has different things, ironically) #21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops, I see I didn't finish my review. The fix here with sites/default/files on a mutagen-enabled system is important.
README.md
Outdated
git clone https://git.drupalcode.org/project/drupal.git drupal | ||
cd drupal | ||
ddev config --project-type=drupal10 | ||
ddev config --project-type=drupal10 --omit-containers=db --docroot="" --php-version=8.3 --disable-settings-management --nodejs-version=20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For folks with mutagen enabled (most everybody on macOS) the drupal*
project types do a bind-mount in sites/default/files. That means that sites/default/files cannot actually be easily deleted, and thus ddev drupal
is perpetually complaining that "drupal is already installed". It's annoying. This replaces the default upload_dirs (sites/default/files) with a dummy directory (.ddev/tmp) so that doesn't happen any more.
(Side note: Why can the web UI and drush do an install just fine with these things existing and silly ddev drupal can't?)
ddev config --project-type=drupal10 --omit-containers=db --docroot="" --php-version=8.3 --disable-settings-management --nodejs-version=20 | |
ddev config --project-type=drupal10 --omit-containers=db --docroot="" --php-version=8.3 --disable-settings-management --nodejs-version=20 --upload-dirs=.ddev/tmp |
A couple of suggestions @T-Fletcher -
|
Thanks for the advice @rfay, this as my first time working with multiple devs on the same issue. I'll be sure to use feature branches and preserve the work even when closing the MR. Thanks! |
This patch makes a few tweaks to streamline initial installation:
sites/default/files
andsites/default/settings.php
afterddev
creates them when setting the project type - if they are present whenddev drupal install
is run, Drupal errors saying it's already installed.yarn
version and enablescorepack
, see yarn v4 #12.drush
, if desired.For a more detailed breakdown, see this gist.