fix: tests were using mysql instead of sqlite #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simesy
added a commit
to simesy/ddev-drupal-core-dev
that referenced
this pull request
Apr 29, 2024
|
Discussed this with @rfay in Slack and instead we're going to move to using mariadb as the default |
simesy
added a commit
to simesy/ddev-drupal-core-dev
that referenced
this pull request
Apr 29, 2024
simesy
added a commit
to simesy/ddev-drupal-core-dev
that referenced
this pull request
May 1, 2024
rfay
pushed a commit
to rfay/ddev-drupal-core-dev
that referenced
this pull request
May 1, 2024
justafish
pushed a commit
that referenced
this pull request
May 23, 2024
* DDEV 1.23 compatiblity, Drupal core yarn/sqlite compatibility. Docs. * Need to use sqlite now b/c no mysql. From /pull/27/files. * Remove install of sqlite3 and make dependent on DDEV v1.23.1 * Run tests now that sqlite 3.45 in DDEV release * Dockerfile is gone, don't try to install it * add back in omit_containers, can remove farther down the line * Remove --verbose from phpunit command, not supported in phpunit 10 --------- Co-authored-by: Simon Hobbs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add-on is very opinionated about using sqlite.
However, I happened to notice a gazillion tables being created in the mariadb database... because the tests were using the mysql URL.
This PR changes the SIMPLETEST_DB in the two phpunit.xml files so it uses the sqlite db.
Without this, nearly no tests can run successfully as in current proposed
omit_containers[db]