Skip to content

Changed to allow phpunit.xml file in project root. #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

joachim-n
Copy link

No description provided.

@AKocherhin
Copy link

Hi @joachim-n
Might be better put "Allow phpunit.xml file in project root" into its own command
And we can call i something like
ddev phpunit_root

or use some another flag for example --root_conf
What do you think?

@joachim-n
Copy link
Author

I think it's better UX if it's automatic.

I don't think a separate command or a flag makes sense -- you either have it set up with phpunit.xml in the root, or you're using the one in core, and it's like that for your project all the time.

@AKocherhin
Copy link

ok. I agree.
in this case, we need changes in documentations too.
Could you please add?

@justafish
Copy link
Owner

Thanks for the PR @joachim-n - core/phpunit.xml is already used by this project and gitignored, so you're welcome to modify it for your own purposes or run ddev exec phpunit for your own custom flags.

@justafish justafish closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants