Upgrade to node 0.10.x segfaults

[jeffwad]

Hi,

I've just upgraded to node 0.10. from the last stable 0.8 release. Node midi now, sadly, segfaults when required.

I've done the obvious (to my mind), and rebuilt/reinstalled it; but to no avail. I tried giving it a go with this (https://github.com/ddopson/node-segfault-handler) but haven't had any luck getting any output yet. I'll be having another go as soon as I have time.

I'm no node expert, so If there is something I should have done ready for release 0.10 I'd be happy to do it if I knew what it was.

Cheers

Si

[justinlatimer]

If you've done npm rebuild after upgrading and you're getting the problem, then it's a bug. I'll look at it as soon as I can (not sure when that will be).

[maxmechanic]

I was getting a "Bus error: 10" (which from SO-searching seems to be related to segmentation errors) message running the most recent stable 0.10 release and saw this issue, so I've tried downgrading to 8.5 and 8.9 and got more explicit segfaults.

In case it's helpful, these were my logs from doing a rebuild:

0.8.5:

In file included from ../src/node-midi.cpp:8:
../src/lib/RtMidi/RtMidi.cpp:473:26: warning: implicit conversion of NULL
      constant to 'MIDIEntityRef' (aka 'unsigned int') [-Wnull-conversion]
  MIDIEntityRef entity = NULL; 

0.8.9:

../src/lib/RtMidi/RtMidi.cpp:473:26: warning: implicit conversion of NULL
      constant to 'MIDIEntityRef' (aka 'unsigned int') [-Wnull-conversion]
  MIDIEntityRef entity = NULL;

0.10.5:

../src/lib/RtMidi/RtMidi.cpp:473:26: warning: implicit conversion of NULL
      constant to 'MIDIEntityRef' (aka 'unsigned int') [-Wnull-conversion]
  MIDIEntityRef entity = NULL;

[justinlatimer]

This looks like something different to the above segfault issue. Could you please create a separate issue so it can be tracked better?

On 20/06/2013, at 2:25 PM, Ashley Scott notifications@github.com wrote:

weirdly, this issue has arisen for me on the following machine/node env:

OSX10.7.5, latest xcode
node & npm installed via mac ports (node: v0.10.12/npm: 1.2.30)

i.e. this is a new environment, macports just grabbed the latest versions avail

npm is fetching midi 0.7.0 from the repo

When I do 'npm install midi' - this is what I get, immediately after the node-gyp rebuild:

CXX(target) Release/obj.target/midi/src/node-midi.o
In file included from ../src/node-midi.cpp:8:
../src/lib/RtMidi/RtMidi.cpp:473:26: warning: implicit conversion of NULL
constant to 'MIDIEntityRef' (aka 'unsigned int') [-Wnull-conversion]
MIDIEntityRef entity = NULL;

0

& the module is not built, so 'require('midi')' fails. Anyone have a known working set of versions?

A

�\
Reply to this email directly or view it on GitHub.

yep - done, yes I should have figured that.

ta Ash

On Fri, Jun 21, 2013 at 4:42 PM, Justin Latimer notifications@github.comwrote:

This looks like something different to the above segfault issue. Could you
please create a separate issue so it can be tracked better?

On 20/06/2013, at 2:25 PM, Ashley Scott notifications@github.com wrote:

weirdly, this issue has arisen for me on the following machine/node env:

OSX10.7.5, latest xcode
node & npm installed via mac ports (node: v0.10.12/npm: 1.2.30)

i.e. this is a new environment, macports just grabbed the latest
versions avail

npm is fetching midi 0.7.0 from the repo

When I do 'npm install midi' - this is what I get, immediately after the
node-gyp rebuild:

CXX(target) Release/obj.target/midi/src/node-midi.o
In file included from ../src/node-midi.cpp:8:
../src/lib/RtMidi/RtMidi.cpp:473:26: warning: implicit conversion of
NULL
constant to 'MIDIEntityRef' (aka 'unsigned int') [-Wnull-conversion]
MIDIEntityRef entity = NULL;

0

& the module is not built, so 'require('midi')' fails. Anyone have a
known working set of versions?

A

\
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/16#issuecomment-19800677
.

computing, electronics, music, film
Ashley Scott
0430 122 207
http://cautiousoptimism.net
http://www.catfingers.net

[carlos8f]

same problem here :(

[yocontra]

I don't get a segfault if I npm install (it just fails silently) but when cloning and trying to run the tests it does. Here is the stack

Don-Juan-PC:node-midi contra$ node test/input-test.js
PID 72640 received SIGSEGV for address: 0x11
0   segfault_handler.node               0x0000000100afdb8b _ZL16segfault_handleriP9__siginfoPv + 191
1   libsystem_c.dylib                   0x00007fff865f194a _sigtramp + 26
2   CoreMIDI                            0x0000000101952350 _ZL17_BootAbsoluteTime + 11872
3   midi.node                           0x0000000100fea05f _ZN13NodeMidiInput3NewERKN2v89ArgumentsE + 85
4   node                                0x0000000100170750 _ZN2v88internalL30Builtin_HandleApiCallConstructENS0_12_GLOBAL__N_116BuiltinArgumentsILNS0_21BuiltinExtraArgumentsE1EEEPNS0_7IsolateE + 544
5   ???                                 0x00001babda70618e 0x0 + 30424918155662
6   ???                                 0x00001babda7244d7 0x0 + 30424918279383

[vkoop]

I also get a segmentation fault when i try to run test/input-test.js.

I would really love to the module! I'm using node v0.10.13

[randallagordon]

On Ubuntu 12.04 I'm getting segfaults with node v0.10.12 but not with v0.10.8.

[uberscientist]

I'm getting a segfault with node v0.10.21 at this line: var input = new midi.input(); -- I am able to require the module without any apparent problems.

I'll poke around and see if I can figure anything out...

[drewish]

So on OS X 10.9 and Node 0.10.22 my stack trace looked like:

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   node                            0x0000000100125cf7 uv_unref + 32
1   midi.node                       0x00000001009e41a5 NodeMidiInput::New(v8::Arguments const&) + 85 (v8.h:4297)
2   node                            0x00000001001662c4 v8::internal::Builtin_HandleApiCallConstruct(v8::internal::(anonymous namespace)::BuiltinArguments<(v8::internal::BuiltinExtraArguments)1>, v8::internal::Isolate*) + 512
3   ???                             0x00003c0778f0618e 0 + 66002791457166

The relevant section of the source:

    static v8::Handle<v8::Value> New(const v8::Arguments& args)
    {
        v8::HandleScope scope;
        NodeMidiInput* input = new NodeMidiInput();
        input->message_async.data = input;
        uv_async_init(uv_default_loop(), &input->message_async, NodeMidiInput::EmitMessage);
        uv_unref((uv_handle_t*)uv_default_loop());
        input->Wrap(args.This());
        return args.This();
    }

I couldn't quite figure out what: uv_unref((uv_handle_t*)uv_default_loop()); was there to do so I tried commenting it out, rebuilt and then:

amorton@pavlov:~/projects/node-midi% node test/input-test.js
1
MidiKeys
m:144,46,95 d:0
m:144,46,0 d:0.168570572
m:144,47,95 d:0.000112732
m:144,47,0 d:0.017246667

Which is to say it started working. Maybe the maintainers can weigh in why that was there?

[drewish]

It seems like that line carried over when the code was upgraded from libev: b481aea#diff-33494fc3bfb02f47665c320bb90d43e6L254

The libev code originated here: adb62e3#diff-33494fc3bfb02f47665c320bb90d43e6R196

I can't find a corresponding ev_ref() or uv_ref() in either so it seems like the line might have been copy/pasted in from some other source?

I'm going to open up a PR to remove this line.