Skip to content

Drop dev.dirs:directories dependency #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2023
Merged

Drop dev.dirs:directories dependency #14

merged 2 commits into from
Jun 23, 2023

Conversation

jsjant
Copy link

@jsjant jsjant commented Jun 23, 2023

Closes issue #13

parttimenerd
parttimenerd requested changes Jun 23, 2023
View reviewed changes
Copy link
Member

@parttimenerd parttimenerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for some minor changes :)

parttimenerd
parttimenerd approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@parttimenerd parttimenerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@parttimenerd parttimenerd merged commit 4708ece into jvm-profiling-tools:main Jun 23, 2023
@jsjant jsjant deleted the remove-jvm-dirs branch June 26, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parttimenerd parttimenerd parttimenerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjant @parttimenerd