Skip to content

Conversation

efmanu
Copy link

@efmanu efmanu commented May 29, 2020

Modified line 38 in core.jl to avoid error mentioned in #7

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2020

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   58.40%   58.40%           
=======================================
  Files           3        3           
  Lines         113      113           
=======================================
  Hits           66       66           
  Misses         47       47           
Impacted Files Coverage Δ
src/core.jl 94.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5a8b9a...30058e9. Read the comment docs.

@jw3126
Copy link
Owner

jw3126 commented May 29, 2020

Thanks! Can you add some unit tests? Feel free to add an Autodiff package as a test only dependency.

@jw3126
Copy link
Owner

jw3126 commented May 29, 2020

(If you are not sure how to do that, just ping me)

@efmanu
Copy link
Author

efmanu commented Jun 9, 2020

I am not sure how to do that...sorry

@jw3126
Copy link
Owner

jw3126 commented Jun 9, 2020

Alright, I am happy to walk you through this. Can you provide a code snippet that exhibits the bug? Something like:

using ReverseDiff
using VoxelRayTracers

# some code that involes ray tracing and autodiff that crashes without this PR.

@efmanu
Copy link
Author

efmanu commented Jun 12, 2020

I will try to make one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants