Skip to content

Conversation

cixtor
Copy link
Contributor

@cixtor cixtor commented Oct 6, 2016

This pull-request fixes bug in the Markdown parser used by GitHub to translate [x] into HTML checkboxes, the way it is currently written makes the transpiler believe that the text in between parenthesis is actually part of a Markdown link with this syntax [title](href) which makes me believe that the parser is taking /\[x\][^(]+\([^)]+\)/ (notice the pattern in between the braces and the parenthesis).

So instead of this:

... it is rendering this:

@jwasham jwasham merged commit 5d4c7c1 into jwasham:master Oct 6, 2016
jwasham pushed a commit that referenced this pull request Oct 11, 2016
 完成 711 到 1318 行翻译
jwasham pushed a commit that referenced this pull request Oct 11, 2016
Merge pull request #4 from Newt0n/master
jwasham pushed a commit that referenced this pull request Jan 11, 2017
translate Don't feel you aren't smart enough
jwasham pushed a commit that referenced this pull request Oct 11, 2017
Before you Get Started topic translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants