Skip to content

Bug or outdated/wrong comment? #3418

Closed
Closed
@cloudhan

Description

@cloudhan

When I skimming through some code, I find

kaldi/src/util/stl-utils.h

Lines 98 to 109 in 8ce3a95

template<class T>
void CopySetToVector(const unordered_set<T> &s, std::vector<T> *v) {
// adds members of s to v, in sorted order from lowest to highest
// (because the set was in sorted order).
KALDI_ASSERT(v != NULL);
v->resize(s.size());
typename unordered_set<T>::const_iterator siter = s.begin(), send = s.end();
typename std::vector<T>::iterator viter = v->begin();
for (; siter != send; ++siter, ++viter) {
*viter = *siter;
}
}

It states (because the set was in sorted order). But the set is an unordered_set, is it a bug or simply forgetting to remove the comment when copying code from the set version of CopySetToVector?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions