Improve API #406
Merged
Improve API #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 88c140d | Previous: fa50586 | Ratio |
|---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 |
19205.432832782702 iter/sec (stddev: 0.000003517431971958828) |
18940.218986909043 iter/sec (stddev: 0.0000017902529485175662) |
0.99 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 |
409.9927533779753 iter/sec (stddev: 0.00012307165242456702) |
435.4945855394223 iter/sec (stddev: 0.00000828856426769497) |
1.06 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 |
14.41817138980679 iter/sec (stddev: 0.000013863535552477134) |
14.440028965167407 iter/sec (stddev: 0.0001451497181618794) |
1.00 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 |
88.05278038629801 iter/sec (stddev: 0.0001504693531871996) |
87.22067638352203 iter/sec (stddev: 0.00012580624647685356) |
0.99 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions |
26633.853759273363 iter/sec (stddev: 0.000004187627779854864) |
25277.06826471292 iter/sec (stddev: 0.000004220791088877952) |
0.95 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions |
1798.0194815379098 iter/sec (stddev: 0.000028564285532802612) |
1817.5752437531671 iter/sec (stddev: 0.000028229329049720055) |
1.01 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions |
105.78458067130953 iter/sec (stddev: 0.005136427830469673) |
94.38259031575035 iter/sec (stddev: 0.006713387392543654) |
0.89 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions |
127.16926039712881 iter/sec (stddev: 0.00015830473272127833) |
125.55514836626152 iter/sec (stddev: 0.00019261291734703524) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Have a class e.g., Tree/BinaryTree/DAG that handles construct, export, helper, etc. methods instead of import multiple functions
Testing
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)