Skip to content

Conversation

VladimirFilonov
Copy link
Contributor

Introduced editable enrichments for incidents with UI components and API endpoints. Users can now add, edit, or remove enrichments dynamically, with changes propagated to the database and frontend in real-time.

Closes #3552

📑 Description

Screen.Recording.2025-04-08.at.17.52.41.mov

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Introduced editable enrichments for incidents with UI components and API endpoints. Users can now add, edit, or remove enrichments dynamically, with changes propagated to the database and frontend in real-time.
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Apr 8, 2025
Copy link

vercel bot commented Apr 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2025 7:11am

@dosubot dosubot bot added API API related issues Feature A new feature UI User interface related issues labels Apr 8, 2025
Updated query result handling to address cases where no result is returned. The change ensures variables are only unpacked if the query yields a valid result, preventing potential errors and improving code robustness.
@talboren
Copy link
Member

talboren commented Apr 8, 2025

🕺🏼

Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - would try to wrap it up with a few tests first, at least for the enrichment part on the backend, making sure that we have desired state at all times

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 9, 2025
@VladimirFilonov VladimirFilonov merged commit 7044d35 into main Apr 10, 2025
26 of 27 checks passed
@VladimirFilonov VladimirFilonov deleted the feat/3552-incident-custom-fields-and-edit-option branch April 10, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API related issues Feature A new feature lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files. UI User interface related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Incident custom fields and edit option
2 participants